Re: [PATCH v2 3/4] target/ppc: Make checkstop actually stop the system

[Nicholas Piggin]

On Wed Jun 28, 2023 at 7:33 PM AEST, Richard Henderson wrote:
> On 6/27/23 15:46, Nicholas Piggin wrote:
> > +    vm_stop(RUN_STATE_GUEST_PANICKED);
>
> Calling qemu_system_guest_panicked(NULL) seems to be more correct.

I'll have a look.

> Though I'm not really sure the difference from cpu_abort(), which would also 
> care for 
> dumping cpu state.

cpu_abort() just kills qemu, so you can't inspect anything. This way
e.g., gdb server and monitor stay up. Seems like you can even re-start
it(?). This is close to what we want short of models for BMC and host
debug logic.

Thanks,
Nick