|
| From: | Richard Henderson |
| Subject: | Re: [PULL 3/5] tcg: add perfmap and jitdump |
| Date: | Thu, 29 Jun 2023 14:59:00 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
On 6/29/23 13:31, Philippe Mathieu-Daudé wrote:
diff --git a/tcg/tcg.c b/tcg/tcg.c index da91779890..9b7df71e7a 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -61,6 +61,7 @@ #include "exec/log.h" #include "tcg/tcg-ldst.h" #include "tcg-internal.h" +#include "accel/tcg/perf.h"Is it OK to include an header from QEMU's accel/tcg/ here? I thought we wanted to keep tcg/ kinda independant (or maybe this is already too late and this isn't a concern anymore).
It's not ideal, no. Perf really should live in tcg/. r~
| [Prev in Thread] | Current Thread | [Next in Thread] |