Re: [PATCH v3 05/37] crypto: Add aesenc_SB_SR_AK

[Richard Henderson]

On 6/29/23 17:45, Max Chou wrote:
> On 2023/6/20 7:07 PM, Richard Henderson wrote:
>
> > diff --git a/include/crypto/aes-round.h b/include/crypto/aes-round.h
> > new file mode 100644
> > index 0000000000..d675d2468f
> > --- /dev/null
> > +++ b/include/crypto/aes-round.h
> > @@ -0,0 +1,44 @@
> > +/*
> > + * AES round fragments, generic version
> > + * SPDX-License-Identifier: GPL-2.0-or-later
> > + *
> > + * Copyright (C) 2023 Linaro, Ltd.
> > + */
> > +
> > +#ifndef CRYPTO_AES_ROUND_H
> > +#define CRYPTO_AES_ROUND_H
> > +
> > +/* Hosts with acceleration will usually need a 16-byte vector type. */
> > +typedef uint8_t AESStateVec __attribute__((vector_size(16)));
> > +
> > +typedef union {
> > +    uint8_t b[16];
> > +    uint32_t w[4];
> > +    uint64_t d[4];
> > +    AESStateVec v;
> > +} AESState;
> Should we change the length of d from 4 to 2 ?

Yes, definitely a typo.

r~