[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 08/17] hw/pci-host/i440fx: Add "i440fx" child property in boar
From: |
Bernhard Beschow |
Subject: |
[PATCH v3 08/17] hw/pci-host/i440fx: Add "i440fx" child property in board code |
Date: |
Fri, 30 Jun 2023 09:37:11 +0200 |
The parent-child relation is usually established near a child's qdev_new(). For
i440fx this allows for reusing the machine parameter, thus avoiding
qdev_get_machine() which relies on a global variable.
Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/i386/pc_piix.c | 2 ++
hw/pci-host/i440fx.c | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 6a5b6dad2f..26e8473a4d 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -202,6 +202,8 @@ static void pc_init1(MachineState *machine,
memory_region_init(pci_memory, NULL, "pci", UINT64_MAX);
rom_memory = pci_memory;
i440fx_host = qdev_new(host_type);
+ object_property_add_child(OBJECT(machine), "i440fx",
+ OBJECT(i440fx_host));
hole64_size = object_property_get_uint(OBJECT(i440fx_host),
PCI_HOST_PROP_PCI_HOLE64_SIZE,
&error_abort);
diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c
index 61e7b97ff4..d95d9229d3 100644
--- a/hw/pci-host/i440fx.c
+++ b/hw/pci-host/i440fx.c
@@ -259,7 +259,6 @@ PCIBus *i440fx_init(const char *pci_type,
b = pci_root_bus_new(dev, NULL, pci_address_space,
address_space_io, 0, TYPE_PCI_BUS);
s->bus = b;
- object_property_add_child(qdev_get_machine(), "i440fx", OBJECT(dev));
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
d = pci_create_simple(b, 0, pci_type);
--
2.41.0
- [PATCH v3 00/17] Q35 and I440FX host bridge QOM cleanup, Bernhard Beschow, 2023/06/30
- [PATCH v3 01/17] hw/i386/pc_q35: Resolve redundant q35_host variable, Bernhard Beschow, 2023/06/30
- [PATCH v3 02/17] hw/pci-host/q35: Fix double, contradicting .endianness assignment, Bernhard Beschow, 2023/06/30
- [PATCH v3 03/17] hw/pci-host/q35: Initialize PCMachineState::bus in board code, Bernhard Beschow, 2023/06/30
- [PATCH v3 05/17] hw/pci-host/q35: Initialize PCI_HOST_BYPASS_IOMMU property from board code, Bernhard Beschow, 2023/06/30
- [PATCH v3 06/17] hw/pci-host/q35: Make some property name macros reusable by i440fx, Bernhard Beschow, 2023/06/30
- [PATCH v3 15/17] hw/pci-host/i440fx: Add I440FX_HOST_PROP_PCI_TYPE property, Bernhard Beschow, 2023/06/30
- [PATCH v3 04/17] hw/pci/pci_host: Introduce PCI_HOST_BYPASS_IOMMU macro, Bernhard Beschow, 2023/06/30
- [PATCH v3 07/17] hw/i386/pc_piix: Turn some local variables into initializers, Bernhard Beschow, 2023/06/30
- [PATCH v3 09/17] hw/pci-host/i440fx: Replace magic values by existing constants, Bernhard Beschow, 2023/06/30
- [PATCH v3 08/17] hw/pci-host/i440fx: Add "i440fx" child property in board code,
Bernhard Beschow <=
- [PATCH v3 12/17] hw/pci-host/i440fx: Make MemoryRegion pointers accessible as properties, Bernhard Beschow, 2023/06/30
- [PATCH v3 11/17] hw/pci-host/i440fx: Move i440fx_realize() into PCII440FXState section, Bernhard Beschow, 2023/06/30
- [PATCH v3 16/17] hw/pci-host/i440fx: Resolve i440fx_init(), Bernhard Beschow, 2023/06/30
- [PATCH v3 14/17] hw/pci-host/i440fx: Add PCI_HOST_{ABOVE, BELOW}_4G_MEM_SIZE properties, Bernhard Beschow, 2023/06/30
- [PATCH v3 17/17] hw/i386/pc_piix: Move i440fx' realize near its qdev_new(), Bernhard Beschow, 2023/06/30
- [PATCH v3 13/17] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property, Bernhard Beschow, 2023/06/30
- [PATCH v3 10/17] hw/pci-host/i440fx: Have common names for some local variables, Bernhard Beschow, 2023/06/30