Re: [PATCH v6 02/20] hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not set

[Daniel Henrique Barboza]

On 6/30/23 04:36, Michael Tokarev wrote:
> 29.06.2023 00:30, Daniel Henrique Barboza wrote:
> > The absence of a satp mode in riscv_host_cpu_init() is causing the
> > following error:
> >
> > $ sudo ./qemu/build/qemu-system-riscv64  -machine virt,accel=kvm \
> >      -m 2G -smp 1  -nographic -snapshot \
> >      -kernel ./guest_imgs/Image \
> >      -initrd ./guest_imgs/rootfs_kvm_riscv64.img \
> >      -append "earlycon=sbi root=/dev/ram rw" \
> >      -cpu host
> > **
> > ERROR:../target/riscv/cpu.c:320:satp_mode_str: code should not be
> > reached
> > Bail out! ERROR:../target/riscv/cpu.c:320:satp_mode_str: code should
> > not be reached
> > Aborted
>
> Hi!
>
> Not a review/comment for the change itself, but a question about your
> work environment.
>
> Why do you run qemu with sudo?  Is it just because your user lacks access
> to /dev/kvm device node (which is fixed by adding it to kvm group) ?

Yes, it's because of /dev/kvm device access. These KVM tests were done in
an emulated environment that don't have UAC properly set.

> I find it a bit worrying to see people run development as root and the
> recipes to run it as root ens up in even in commit messages.  I think
> it's not good practice to do it like this, but more important is to
> teach users to do it this way. And this is more serious than one might
> think.

Just removed all 'sudo' references from commit msgs for the next version.


Daniel

> Thanks,
>
> /mjt