Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs

[Bernhard Beschow]

Am 30. Juni 2023 07:29:21 UTC schrieb Olaf Hering <olaf@aepfle.de>:
>Wed, 28 Jun 2023 09:27:16 +0000 Bernhard Beschow <shentey@gmail.com>:
>
>> Would you mind sending a patch fixing the BMIBA register to be reset as 32 
>> bit?
>
>Will do so next week.

Great! Perhaps it could then be picked up by maintainers together with my other 
IDE changes.

>
>Are the specs for this chipset available,

Yes. Have a look for piix3/piix4 here: 
https://www.intel.com/design/archives/chipsets/440/index.htm

> does this address really need
>to be accessed in quantities of u32, or is perhaps u16 required? I guess
>for this specific bug pci_set_word may work as well.
>
>Either way, commit e6a71ae327a388723182a504bb253777ec36869b was wrong.
>Does the comment added in this commit mean, the quantity is really u32?

As per the datasheet (and per the comment in the source code) the BMIBA 
register is 32 bit. Search the datasheet for the register name and you'll also 
find its default value which it holds after reset.

Best regards,
Bernhard

>
>
>Olaf