Re: [PATCH 3/4] ppc/pnv: Add P10 quad ops

[Daniel Henrique Barboza]

On 6/30/23 04:44, Cédric Le Goater wrote:
> On 6/30/23 09:35, Joel Stanley wrote:
> > On Fri, 30 Jun 2023 at 07:30, Frederic Barrat <fbarrat@linux.ibm.com> wrote:
> > > On 30/06/2023 05:55, Joel Stanley wrote:
> > > > diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> > > > index b9a57463aec4..7fff2fd9e298 100644
> > > > --- a/hw/ppc/pnv_core.c
> > > > +++ b/hw/ppc/pnv_core.c
> > >
> > > > +static uint64_t pnv_quad_power10_xscom_read(void *opaque, hwaddr addr,
> > > ...
> > > > +        qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
> > >
> > >                                            ^^^ reading
> > >
> > > I'm guessing we'll need to flush out that function pretty soon, so not
> > > worth resending.
> >
> > Thanks, good catch. It's incorrect in the p9 callback too.
> >
> > I had it fixed locally along with a re-wording to make it clear the
> > message was for unimplemented operations, but decided not to send
> > that.
>
>
> There is still time for a v2 ! Please keep the R-b.

Since you're sending a v2 please fix the 80+ char line in patch 4 to make
checkpatch.pl happy:


-static void pnv_quad_power10_xscom_write(void *opaque, hwaddr addr, uint64_t 
val,
-                                         unsigned int width)
+static void pnv_quad_power10_xscom_write(void *opaque, hwaddr addr,
+                                         uint64_t val, unsigned int width)


I'll not queue the series for now.


Daniel

> Thanks,
>
> C.