[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 0/6] migration: Test the new "file:" migration
From: |
Fabiano Rosas |
Subject: |
[PATCH v3 0/6] migration: Test the new "file:" migration |
Date: |
Fri, 30 Jun 2023 18:28:56 -0300 |
Based-on:
[PATCH V4 0/2] migration file URI
1688135108-316997-1-git-send-email-steven.sistare@oracle.com">https://lore.kernel.org/r/1688135108-316997-1-git-send-email-steven.sistare@oracle.com
Since v2:
- removed the extra setup event. Libvirt has been enabling events for
a long time, it should be safe
- fixed small issues pointed out by Peter (leaking memory, mmap args)
- stopped looking at the error string in the QMP error test
- skipped the check for zeroes on non-linux platforms
CI run: https://gitlab.com/farosas/qemu/-/pipelines/917665246
v2:
20230628165542.17214-1-farosas@suse.de">https://lore.kernel.org/r/20230628165542.17214-1-farosas@suse.de
- added the force-emit-setup-event property
- added verification that the skipped region is empty
CI run: https://gitlab.com/farosas/qemu/-/pipelines/914915941
v1:
20230626182210.8792-1-farosas@suse.de">https://lore.kernel.org/r/20230626182210.8792-1-farosas@suse.de
Here's the test for the file: migration.
I hit an issue with the setting of migration status. If we call
query-migrate too soon after migrate-incoming, the query returns an
empty response because we're not setting the MIGRATION_STATUS_SETUP in
the incoming path. We just send the event, but never actually change
state.
Aside from the fix, there's some tidying up to avoid duplicating too
much code in the tests.
Thanks
CI run: https://gitlab.com/farosas/qemu/-/pipelines/912226554
Fabiano Rosas (6):
tests/qtest: migration: Expose migrate_set_capability
tests/qtest: migration: Add migrate_incoming_qmp helper
tests/qtest: migration: Use migrate_incoming_qmp where appropriate
migration: Set migration status early in incoming side
tests/qtest: migration: Add support for negative testing of
qmp_migrate
tests/qtest: migration-test: Add tests for file-based migration
migration/migration.c | 7 +-
tests/qtest/libqtest.c | 33 +++++++
tests/qtest/libqtest.h | 28 ++++++
tests/qtest/meson.build | 1 +
tests/qtest/migration-helpers.c | 60 +++++++++++++
tests/qtest/migration-helpers.h | 10 +++
tests/qtest/migration-test.c | 138 +++++++++++++++++++++++++-----
tests/qtest/virtio-net-failover.c | 77 ++---------------
8 files changed, 261 insertions(+), 93 deletions(-)
--
2.35.3
- [PATCH v3 0/6] migration: Test the new "file:" migration,
Fabiano Rosas <=
- [PATCH v3 1/6] tests/qtest: migration: Expose migrate_set_capability, Fabiano Rosas, 2023/06/30
- [PATCH v3 4/6] migration: Set migration status early in incoming side, Fabiano Rosas, 2023/06/30
- [PATCH v3 3/6] tests/qtest: migration: Use migrate_incoming_qmp where appropriate, Fabiano Rosas, 2023/06/30
- [PATCH v3 2/6] tests/qtest: migration: Add migrate_incoming_qmp helper, Fabiano Rosas, 2023/06/30
- [PATCH v3 5/6] tests/qtest: migration: Add support for negative testing of qmp_migrate, Fabiano Rosas, 2023/06/30
- [PATCH v3 6/6] tests/qtest: migration-test: Add tests for file-based migration, Fabiano Rosas, 2023/06/30