Re: [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall_d

From:	Warner Losh
Subject:	Re: [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall_defs
Date:	Tue, 8 Aug 2023 20:43:26 -0600

On Tue, Aug 8, 2023 at 3:23 PM Richard Henderson <richard.henderson@linaro.org> wrote:

On 8/7/23 23:07, Karim Taha wrote:
> + uint32_t st_flags; /* user defined flags for file */
> + __uint32_t st_gen; /* file generation number */
> + __int32_t st_lspare;

Oh, drop the __ types.

Agreed. The original from the blitz branch copied from FreeBSD's stat.h file which

used the __ types to avoid namespace pollution... a constraint we don't have here.

Warner

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h, (continued)
- [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h, Karim Taha, 2023/08/08
  - Re: [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h, Richard Henderson, 2023/08/08
    - Re: [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h, Warner Losh, 2023/08/08
    - Re: [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h, Richard Henderson, 2023/08/08
    - Re: [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h, Warner Losh, 2023/08/08
- [PATCH 07/33] Add struct target_stat to bsd-user/syscall_defs.h, Karim Taha, 2023/08/08
  - Re: [PATCH 07/33] Add struct target_stat to bsd-user/syscall_defs.h, Richard Henderson, 2023/08/08
- [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall_defs, Karim Taha, 2023/08/08
  - Re: [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall_defs, Richard Henderson, 2023/08/08
  - Re: [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall_defs, Richard Henderson, 2023/08/08
    - Re: [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall_defs, Warner Losh <=
- [PATCH 10/33] Add struct target_freebsd_fhandle and fcntl flags to bsd-user/syscall_defs.h, Karim Taha, 2023/08/08
  - Re: [PATCH 10/33] Add struct target_freebsd_fhandle and fcntl flags to bsd-user/syscall_defs.h, Richard Henderson, 2023/08/08
    - Re: [PATCH 10/33] Add struct target_freebsd_fhandle and fcntl flags to bsd-user/syscall_defs.h, Warner Losh, 2023/08/08
- [PATCH 03/33] Update the definitions of __put_user and __get_user macros, Karim Taha, 2023/08/08
  - Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros, Richard Henderson, 2023/08/08
    - Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros, Warner Losh, 2023/08/08
    - Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros, Richard Henderson, 2023/08/08
    - Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros, Warner Losh, 2023/08/08
    - Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros, Richard Henderson, 2023/08/08
- [PATCH 11/33] Define safe_fcntl macro in bsd-user/syscall_defs.h, Karim Taha, 2023/08/08

Prev by Date: Re: [PATCH 03/33] Update the definitions of __put_user and __get_user macros
Next by Date: Re: [PATCH 08/33] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h
Previous by thread: Re: [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall_defs
Next by thread: [PATCH 10/33] Add struct target_freebsd_fhandle and fcntl flags to bsd-user/syscall_defs.h
Index(es):
- Date
- Thread