Re: [PATCH 4/7] tcg/tcg-op: Document hswap() byte pattern

[Richard Henderson]

On 8/22/23 02:37, Philippe Mathieu-Daudé wrote:
> Document hswap_i32() and hswap_i64(), added in commit
> 46be8425ff ("tcg: Implement tcg_gen_{h,w}swap_{i32,i64}").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   docs/devel/tcg-ops.rst |  4 ++++
>   tcg/tcg-op.c           | 26 +++++++++++++++++++-------
>   2 files changed, 23 insertions(+), 7 deletions(-)
>
> diff --git a/docs/devel/tcg-ops.rst b/docs/devel/tcg-ops.rst
> index 6a166c5665..d9364effd2 100644
> --- a/docs/devel/tcg-ops.rst
> +++ b/docs/devel/tcg-ops.rst
> @@ -486,6 +486,10 @@ Misc
>            into 32-bit output *t0*.  Depending on the host, this may be a 
> simple shift,
>            or may require additional canonicalization.
>   
> +   * - hswap_i32/i64 *t0*, *t1*
> +
> +     - | Swap 16-bit halfwords within a 32/64-bit value.

hswap is not a tcg opcode, so this is incorrect.

This falls into the part of TCG that Peter has mentioned many times: we have opcode 
documentation, but no separate translator front end documentation.


r~