[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/67] ui/console: new_console() cannot fail
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 10/67] ui/console: new_console() cannot fail |
|
Date: |
Wed, 30 Aug 2023 12:07:25 +0100 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Wed, Aug 30, 2023 at 01:37:44PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> There is no code path that could allow a NULL return there.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/console.c | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 05/67] ui/vc: drop have_text, (continued)
- [PATCH 05/67] ui/vc: drop have_text, marcandre . lureau, 2023/08/30
- [PATCH 06/67] ui/console: console_select() regardless of have_gfx, marcandre . lureau, 2023/08/30
- [PATCH 07/67] ui/console: call dpy_gfx_update() regardless of have_gfx, marcandre . lureau, 2023/08/30
- [PATCH 08/67] ui/console: drop have_gfx, marcandre . lureau, 2023/08/30
- [PATCH 09/67] ui/console: get the DisplayState from new_console(), marcandre . lureau, 2023/08/30
- [PATCH 10/67] ui/console: new_console() cannot fail, marcandre . lureau, 2023/08/30
- Re: [PATCH 10/67] ui/console: new_console() cannot fail,
Daniel P . Berrangé <=
- [PATCH 11/67] ui/vc: VC always has a DisplayState now, marcandre . lureau, 2023/08/30
- [PATCH 12/67] ui/vc: move VCChardev declaration at the top, marcandre . lureau, 2023/08/30
- [PATCH 13/67] ui/vc: replace variable with static text attributes default, marcandre . lureau, 2023/08/30
- [PATCH 14/67] ui/vc: fold text_update_xy(), marcandre . lureau, 2023/08/30
- [PATCH 15/67] ui/vc: pass VCCharDev to VC-specific functions, marcandre . lureau, 2023/08/30
- [PATCH 16/67] ui/vc: move VCCharDev specific fields out of QemuConsole, marcandre . lureau, 2023/08/30
- [PATCH 17/67] ui/console: use OBJECT_DEFINE_TYPE for QemuConsole, marcandre . lureau, 2023/08/30