qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 06/13] docs/devel: simplify the minimal checklist


From: Alex Bennée
Subject: Re: [PATCH v3 06/13] docs/devel: simplify the minimal checklist
Date: Fri, 01 Sep 2023 11:08:15 +0100
User-agent: mu4e 1.11.16; emacs 29.1.50

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Ping?
>
> On 5/7/23 13:44, Philippe Mathieu-Daudé wrote:
>> Hi Alex,
>> On 17/11/22 18:25, Alex Bennée wrote:
>>> The bullet points are quite long and contain process tips. Move those
>>> bits of the bullet to the relevant sections and link to them. Use a
>>> table for nicer formatting of the checklist.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Message-Id: <20221111145529.4020801-8-alex.bennee@linaro.org>
>>> ---
>>>   docs/devel/submitting-a-patch.rst | 75 ++++++++++++++++++++-----------
>>>   1 file changed, 49 insertions(+), 26 deletions(-)
>> 
>>> @@ -314,10 +320,12 @@ git repository to fetch the original commit.
>>>   Patch emails must include a ``Signed-off-by:`` line
>>>   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> -For more information see `SubmittingPatches 1.12
>>> -<http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297>`__.
>>> -This is vital or we will not be able to apply your patch! Please use
>>> -your real name to sign a patch (not an alias or acronym).
>> Revisiting this patch, asking for some real name instead of alias
>> was at least helpful during patch review, we could address the
>> contributor by its name. Addressing an acronym is socially weird
>> (at least in my culture netiquette).

Is it that weird? We use nicks all the time on IRC.

The only driver for real names for the signoff is its harder to have
confidence the contribution is valid because you might not be able to
find who is behind an anonymous nick if something comes up later.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



reply via email to

[Prev in Thread] Current Thread [Next in Thread]