Re: [PATCH 26/67] ui/vc: move cursor_timer initialization to QemuTextConsole class

[Marc-André Lureau]

Hi

On Fri, Sep 1, 2023 at 6:29 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Wed, Aug 30, 2023 at 01:38:00PM +0400, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The timer is only relevant when a text console exists.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  ui/console.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> > diff --git a/ui/console.c b/ui/console.c
> > index 8c4a2c83fa..ffa68c3a22 100644
> > --- a/ui/console.c
> > +++ b/ui/console.c
> > @@ -1399,6 +1399,10 @@ qemu_text_console_finalize(Object *obj)
> >  static void
> >  qemu_text_console_class_init(ObjectClass *oc, void *data)
> >  {
> > +    if (!cursor_timer) {
> > +        cursor_timer = timer_new_ms(QEMU_CLOCK_REALTIME,
> > +                                    text_console_update_cursor, NULL);
> > +    }
>
> Any possibility of moving 'cursor_timer' into a field in
> QemuTextConsole ?
>

It's global, so all consoles blink at the same time I suppose. It's
not obvious to me how we could make it a class field either.

thanks

-- 
Marc-André Lureau