[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/52] ui/console: new_console() cannot fail
From: |
marcandre . lureau |
Subject: |
[PULL 10/52] ui/console: new_console() cannot fail |
Date: |
Mon, 4 Sep 2023 15:52:07 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
There is no code path that could allow a NULL return there.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20230830093843.3531473-11-marcandre.lureau@redhat.com>
---
ui/console.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index 24cfd31ad6..ddec68feb7 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -2480,11 +2480,6 @@ static void vc_chr_open(Chardev *chr,
s->surface = qemu_create_displaysurface(width, height);
}
- if (!s) {
- error_setg(errp, "cannot create text console");
- return;
- }
-
s->chr = chr;
drv->console = s;
--
2.41.0
- [PULL 00/52] UI patches, marcandre . lureau, 2023/09/04
- [PULL 01/52] ui: remove qemu_pixman_color() helper, marcandre . lureau, 2023/09/04
- [PULL 02/52] ui: remove qemu_pixman_linebuf_copy(), marcandre . lureau, 2023/09/04
- [PULL 03/52] ui/qmp: move screendump to ui-qmp-cmds.c, marcandre . lureau, 2023/09/04
- [PULL 04/52] ui/vc: replace vc_chr_write() with generic qemu_chr_write(), marcandre . lureau, 2023/09/04
- [PULL 05/52] ui/vc: drop have_text, marcandre . lureau, 2023/09/04
- [PULL 06/52] ui/console: console_select() regardless of have_gfx, marcandre . lureau, 2023/09/04
- [PULL 07/52] ui/console: call dpy_gfx_update() regardless of have_gfx, marcandre . lureau, 2023/09/04
- [PULL 08/52] ui/console: drop have_gfx, marcandre . lureau, 2023/09/04
- [PULL 09/52] ui/console: get the DisplayState from new_console(), marcandre . lureau, 2023/09/04
- [PULL 10/52] ui/console: new_console() cannot fail,
marcandre . lureau <=
- [PULL 11/52] ui/vc: VC always has a DisplayState now, marcandre . lureau, 2023/09/04
- [PULL 12/52] ui/vc: move VCChardev declaration at the top, marcandre . lureau, 2023/09/04
- [PULL 14/52] ui/vc: fold text_update_xy(), marcandre . lureau, 2023/09/04
- [PULL 13/52] ui/vc: replace variable with static text attributes default, marcandre . lureau, 2023/09/04
- [PULL 15/52] ui/vc: pass VCCharDev to VC-specific functions, marcandre . lureau, 2023/09/04
- [PULL 16/52] ui/vc: move VCCharDev specific fields out of QemuConsole, marcandre . lureau, 2023/09/04
- [PULL 17/52] ui/console: use OBJECT_DEFINE_TYPE for QemuConsole, marcandre . lureau, 2023/09/04
- [PULL 18/52] ui/console: change new_console() to use object initialization, marcandre . lureau, 2023/09/04
- [PULL 20/52] ui/console: instantiate a specific console type, marcandre . lureau, 2023/09/04
- [PULL 19/52] ui/console: introduce different console objects, marcandre . lureau, 2023/09/04