[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 50/67] ui/console: move DisplaySurface to its own header
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 50/67] ui/console: move DisplaySurface to its own header |
Date: |
Mon, 4 Sep 2023 14:05:08 +0100 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Mon, Sep 04, 2023 at 04:59:31PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Fri, Sep 1, 2023 at 9:24 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, Aug 30, 2023 at 01:38:24PM +0400, marcandre.lureau@redhat.com wrote:
> > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > >
> > > Mostly for readability reasons.
> > >
> > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > ---
> > > include/ui/console.h | 84 +---------------------------------------
> > > include/ui/surface.h | 91 ++++++++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 92 insertions(+), 83 deletions(-)
> > > create mode 100644 include/ui/surface.h
> > >
> >
> > > diff --git a/include/ui/surface.h b/include/ui/surface.h
> > > new file mode 100644
> > > index 0000000000..37725a303e
> > > --- /dev/null
> > > +++ b/include/ui/surface.h
> > > @@ -0,0 +1,91 @@
> >
> > When you moved the VC bits out of console.h you added a GPL-2.0-or-later
> > SPDX tag, so by implication this ought to gain the same.
> >
>
>
> Done. R-B with that change?
Yep, Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
with the GPL-2.0-or-later addition
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|