Re: [PATCH v5 00/20] linux-user: Implement VDSOs

[Alex Bennée]

Helge Deller <deller@gmx.de> writes:

> On 8/31/23 09:57, Alex Bennée wrote:
>>
>> Richard Henderson <richard.henderson@linaro.org> writes:
>>
>>> On 8/30/23 07:52, Helge Deller wrote:
>>>> On 8/30/23 00:02, Richard Henderson wrote:
>>>>> Changes for v5:
>>>>>     * Integrated cross-compile, via new build-vdso.sh and meson rules.
>>>>>       However, keep the binaries in the tree for hosts which do not
>>>>>       have all of the cross-compile machinery.
>>>>>     * Update our loongarch64 docker image to avoid a binutils bug.
>>>>>
>>>>> Just in case the list eats a binary:
>>>>>     https://gitlab.com/rth7680/qemu/-/tree/lu-vdso
>>>> I pulled that on top of git head, and ran into the build problem
>>>> below.
>>>> Do I miss something?
>>>
>>> No idea, since it worked for me.  Looks like some sort of docker.py 
>>> problem.  Alex?
>>>
>>> In the short term, use --disable-containers so that you only use the
>>> cross-compilers that you have locally installed.
<snip>
>>
>> It looks like it detected podman on this setup. Can you invoke the
>> container from the command line?
>
> Yes, if I run it on the command line:
>
> [deller@p100 _build]$ 'podman' 'run' '--rm' '--label' 
> 'com.qemu.instance.uuid=21e1c0332a2c44b6ae94a71392c57ccf' '--userns=keep-id' 
> '-u' '1000' '-w' '/srv/_build' '-v' '/srv/_build:/srv/_build:rw' '-v' 
> '/home/cvs/qemu/qemu:/home/cvs/qemu/qemu:ro,z' 'qemu/debian-armhf-cross' 
> 'arm-linux-gnueabihf-gcc' '-o' 'linux-user/arm/vdso-le.so' '-nostdlib' 
> '-shared' '-Wl,-use-blx' '-Wl,-h,linux-vdso.so.1' '-Wl,--build-id=sha1' 
> '-Wl,--hash-style=both' 
> '-Wl,-T,../../home/cvs/qemu/qemu/linux-user/arm/vdso.ld' 
> '../../home/cvs/qemu/qemu/linux-user/arm/vdso.S' '-mlittle-endian'
>
> I get this interactive(!!!) output where I can use the cursor keys to swith 
> up/down:
>
> ? Please select an image:
>   ▸ registry.fedoraproject.org/qemu/debian-armhf-cross:latest
>     registry.access.redhat.com/qemu/debian-armhf-cross:latest
>     docker.io/qemu/debian-armhf-cross:latest
>     quay.io/qemu/debian-armhf-cross:latest
>
> I assume the problem is, that we don't want interactive input at this stage?
> Probably this is why I get the error message: "Error: short-name
> resolution enforced but cannot prompt without a TTY" ?

No I think the problem is we need to add dependencies to the target to
ensure the containers are built and available (if they are needed). It
looks like because qemu/debian-armhf-cross isn't available on your local
setup it fails and offers some guesses.

If you run:

  make docker-image-debian-armhf-cross

does the target work afterwards?

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro