[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] qdict: Preserve order for iterating qdict elements
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2] qdict: Preserve order for iterating qdict elements |
Date: |
Mon, 4 Sep 2023 17:38:29 +0100 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Sat, Sep 02, 2023 at 05:40:40PM +0800, William Tsai wrote:
> Changing the structure of qdict so that it can preserve order when
> iterating qdict. This will fix array_properties as it relies on `len-`
> prefixed argument to be set first.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1090
> Signed-off-by: William Tsai <williamtsai1111@gmail.com>
This is a variation of what Markus illustrated a year ago
https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg00758.html
I wasn't a particular fan of that approach at the time.
I've made an alternative proposal here which avoids the broader
impact of this QDict change:
https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg00652.html
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|