[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 11/11] machine: Improve error message when using default RAM b
From: |
David Hildenbrand |
Subject: |
[PATCH v4 11/11] machine: Improve error message when using default RAM backend id |
Date: |
Wed, 6 Sep 2023 14:05:03 +0200 |
For migration purposes, users might want to reuse the default RAM
backend id, but specify a different memory backend.
For example, to reuse "pc.ram" on q35, one has to set
-machine q35,memory-backend=pc.ram
Only then, can a memory backend with the id "pc.ram" be created
manually.
Let's improve the error message by improving the hint. Use
error_append_hint() -- which in turn requires ERRP_GUARD().
Suggested-by: ThinerLogoer <logoerthiner1@163.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Mario Casquero <mcasquer@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/core/machine.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index da699cf4e1..db0c263ff6 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1355,6 +1355,7 @@ out:
void machine_run_board_init(MachineState *machine, const char *mem_path, Error
**errp)
{
+ ERRP_GUARD();
MachineClass *machine_class = MACHINE_GET_CLASS(machine);
ObjectClass *oc = object_class_by_name(machine->cpu_type);
CPUClass *cc;
@@ -1383,9 +1384,13 @@ void machine_run_board_init(MachineState *machine, const
char *mem_path, Error *
numa_uses_legacy_mem()) {
if (object_property_find(object_get_objects_root(),
machine_class->default_ram_id)) {
- error_setg(errp, "object name '%s' is reserved for the default"
- " RAM backend, it can't be used for any other purposes."
- " Change the object's 'id' to something else",
+ error_setg(errp, "object's id '%s' is reserved for the default"
+ " RAM backend, it can't be used for any other purposes",
+ machine_class->default_ram_id);
+ error_append_hint(errp,
+ "Change the object's 'id' to something else or disable"
+ " automatic creation of the default RAM backend by setting"
+ " 'memory-backend=%s' with '-machine'.\n",
machine_class->default_ram_id);
return;
}
--
2.41.0
- [PATCH v4 00/11] memory-backend-file related improvements and VM templating support, David Hildenbrand, 2023/09/06
- [PATCH v4 01/11] nvdimm: Reject writing label data to ROM instead of crashing QEMU, David Hildenbrand, 2023/09/06
- [PATCH v4 02/11] softmmu/physmem: Distinguish between file access mode and mmap protection, David Hildenbrand, 2023/09/06
- [PATCH v4 03/11] backends/hostmem-file: Add "rom" property to support VM templating with R/O files, David Hildenbrand, 2023/09/06
- [PATCH v4 05/11] softmmu/physmem: Bail out early in ram_block_discard_range() with readonly files, David Hildenbrand, 2023/09/06
- [PATCH v4 08/11] docs: Don't mention "-mem-path" in multi-process.rst, David Hildenbrand, 2023/09/06
- [PATCH v4 04/11] softmmu/physmem: Remap with proper protection in qemu_ram_remap(), David Hildenbrand, 2023/09/06
- [PATCH v4 09/11] docs: Start documenting VM templating, David Hildenbrand, 2023/09/06
- [PATCH v4 10/11] softmmu/physmem: Hint that "readonly=on, rom=off" exists when opening file R/W for private mapping fails, David Hildenbrand, 2023/09/06
- [PATCH v4 11/11] machine: Improve error message when using default RAM backend id,
David Hildenbrand <=
- [PATCH v4 07/11] softmmu/physmem: Never return directories from file_ram_open(), David Hildenbrand, 2023/09/06
- [PATCH v4 06/11] softmmu/physmem: Fail creation of new files in file_ram_open() with readonly=true, David Hildenbrand, 2023/09/06
- Re: [PATCH v4 00/11] memory-backend-file related improvements and VM templating support, David Hildenbrand, 2023/09/11