[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/13] io: check there are no qio_channel_yield() coroutines durin
From: |
Eric Blake |
Subject: |
[PULL 04/13] io: check there are no qio_channel_yield() coroutines during ->finalize() |
Date: |
Thu, 7 Sep 2023 20:35:40 -0500 |
From: Stefan Hajnoczi <stefanha@redhat.com>
Callers must clean up their coroutines before calling
object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an
assertion to check this.
This patch is preparation for the fd handler changes that follow.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-ID: <20230830224802.493686-4-stefanha@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
io/channel.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/io/channel.c b/io/channel.c
index 72f0066af55..c415f3fc885 100644
--- a/io/channel.c
+++ b/io/channel.c
@@ -653,6 +653,10 @@ static void qio_channel_finalize(Object *obj)
{
QIOChannel *ioc = QIO_CHANNEL(obj);
+ /* Must not have coroutines in qio_channel_yield() */
+ assert(!ioc->read_coroutine);
+ assert(!ioc->write_coroutine);
+
g_free(ioc->name);
#ifdef _WIN32
--
2.41.0
- [PULL 00/13] NBD patches through 2023-09-07, Eric Blake, 2023/09/07
- [PULL 01/13] qemu-iotests/197: use more generic commands for formats other than qcow2, Eric Blake, 2023/09/07
- [PULL 02/13] nbd: drop unused nbd_receive_negotiate() aio_context argument, Eric Blake, 2023/09/07
- [PULL 04/13] io: check there are no qio_channel_yield() coroutines during ->finalize(),
Eric Blake <=
- [PULL 03/13] nbd: drop unused nbd_start_negotiate() aio_context argument, Eric Blake, 2023/09/07
- [PULL 07/13] qemu-nbd: improve error message for dup2 error, Eric Blake, 2023/09/07
- [PULL 05/13] io: follow coroutine AioContext in qio_channel_yield(), Eric Blake, 2023/09/07
- [PULL 06/13] util/iov: Avoid dynamic stack allocation, Eric Blake, 2023/09/07
- [PULL 08/13] qemu-nbd: define struct NbdClientOpts when HAVE_NBD_DEVICE is not defined, Eric Blake, 2023/09/07
- [PULL 09/13] qemu-nbd: move srcpath into struct NbdClientOpts, Eric Blake, 2023/09/07
- [PULL 10/13] qemu-nbd: put saddr into into struct NbdClientOpts, Eric Blake, 2023/09/07
- [PULL 11/13] qemu-nbd: invent nbd_client_release_pipe() helper, Eric Blake, 2023/09/07
- [PULL 13/13] qemu-nbd: document -v behavior in respect to --fork in man, Eric Blake, 2023/09/07
- [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output, Eric Blake, 2023/09/07