[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/22] hw/arm/armv7m: Clean up local variable shadowing
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 07/22] hw/arm/armv7m: Clean up local variable shadowing |
Date: |
Fri, 8 Sep 2023 13:29:36 +0100 |
On Mon, 4 Sept 2023 at 17:13, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Fix:
>
> hw/arm/armv7m.c: In function ‘armv7m_realize’:
> hw/arm/armv7m.c:520:27: warning: declaration of ‘sbd’ shadows a previous
> local [-Wshadow=compatible-local]
> 520 | SysBusDevice *sbd = SYS_BUS_DEVICE(&s->bitband[i]);
> | ^~~
> hw/arm/armv7m.c:278:19: note: shadowed declaration is here
> 278 | SysBusDevice *sbd;
> | ^~~
> ---
>
> hw/arm/armsse.c: In function ‘armsse_realize’:
> hw/arm/armsse.c:1471:27: warning: declaration of ‘mr’ shadows a previous
> local [-Wshadow=compatible-local]
> 1471 | MemoryRegion *mr;
> | ^~
> hw/arm/armsse.c:917:19: note: shadowed declaration is here
> 917 | MemoryRegion *mr;
> | ^~
> ---
>
> hw/arm/armsse.c:1608:22: warning: declaration of ‘dev_splitter’ shadows a
> previous local [-Wshadow=compatible-local]
> 1608 | DeviceState *dev_splitter = DEVICE(splitter);
> | ^~~~~~~~~~~~
> hw/arm/armsse.c:923:18: note: shadowed declaration is here
> 923 | DeviceState *dev_splitter;
> | ^~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v2 01/22] tcg: Clean up local variable shadowing, (continued)
- [PATCH v2 01/22] tcg: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 02/22] target/arm/tcg: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 03/22] target/arm/hvf: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 04/22] target/mips: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 05/22] target/m68k: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 06/22] target/tricore: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 07/22] hw/arm/armv7m: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- Re: [PATCH v2 07/22] hw/arm/armv7m: Clean up local variable shadowing,
Peter Maydell <=
- [PATCH v2 08/22] hw/arm/virt: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 09/22] hw/arm/allwinner: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 10/22] hw/arm/aspeed: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 11/22] hw/ide/ahci: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 12/22] hw/m68k: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 13/22] hw/microblaze: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 14/22] hw/nios2: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04
- [PATCH v2 15/22] net/eth: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/09/04