Re: [PATCH v2 01/10] target/i386: Add missing feature names in FEAT_VMX_EPT_VPID_CAPS

[Igor Mammedov]

On Fri,  8 Sep 2023 14:45:25 +0200
Tim Wiederhake <twiederh@redhat.com> wrote:

> Add the missing feature names for two bits in the FEAT_VMX_EPT_VPID_CAPS
> cpuid leaf. "vmx-ept-uc" is currently unused, but "vmx-ept-wb" is enabled
> for multiple cpu models.
> 
> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  target/i386/cpu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 24ee67b42d..7c2c48ac06 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -1314,8 +1314,8 @@ FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>          .feat_names = {
>              "vmx-ept-execonly", NULL, NULL, NULL,
>              NULL, NULL, "vmx-page-walk-4", "vmx-page-walk-5",
> -            NULL, NULL, NULL, NULL,
> -            NULL, NULL, NULL, NULL,
> +            "vmx-ept-uc", NULL, NULL, NULL,
> +            NULL, NULL, "vmx-ept-wb", NULL,
>              "vmx-ept-2mb", "vmx-ept-1gb", NULL, NULL,
>              "vmx-invept", "vmx-eptad", "vmx-ept-advanced-exitinfo", NULL,
>              NULL, "vmx-invept-single-context", "vmx-invept-all-context", 
> NULL,