Re: [PULL 24/51] meson: compile bundled device trees

[BALATON Zoltan]

On Fri, 8 Sep 2023, Michael Tokarev wrote:
> 08.09.2023 19:27, Philippe Mathieu-Daudé:
> > On 7/9/23 14:59, Paolo Bonzini wrote:
> > > If dtc is available, compile the .dts files in the pc-bios directory
> > > instead of using the precompiled binaries.
> > >
> > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > ---
> > >   pc-bios/Makefile    | 19 -------------------
> > >   pc-bios/meson.build | 25 +++++++++++++++++++++----
> > >   2 files changed, 21 insertions(+), 23 deletions(-)
> > >   delete mode 100644 pc-bios/Makefile
> >
> > FWIW I'm getting:
> >
> > [50/1419] Generating pc-bios/bamboo.dts with a custom command
> > ../../pc-bios/bamboo.dts:45.9-48.4: Warning (unit_address_vs_reg): /memory: 
> > node has a reg or ranges property, but no unit name
> > ../../pc-bios/bamboo.dts:87.13-154.5: Warning (unit_address_vs_reg): 
> > /plb/opb: node has a reg or ranges property, but no unit name
> > ../../pc-bios/bamboo.dts:198.3-50: Warning (chosen_node_stdout_path): 
> > /chosen:linux,stdout-path: Use 'stdout-path' instead
> > ../../pc-bios/bamboo.dts:87.13-154.5: Warning (interrupts_property): 
> > /plb/opb: Missing interrupt-parent
> > ../../pc-bios/bamboo.dts:100.14-108.6: Warning (interrupts_property): 
> > /plb/opb/ebc: Missing interrupt-parent
> > [51/1419] Generating pc-bios/canyonlands.dts with a custom command
> > ../../pc-bios/canyonlands.dts:47.9-50.4: Warning (unit_address_vs_reg): 
> > /memory: node has a reg or ranges property, but no unit name
> > ../../pc-bios/canyonlands.dts:210.13-429.5: Warning (unit_address_vs_reg): 
> > /plb/opb: node has a reg or ranges property, but no unit name
> > ../../pc-bios/canyonlands.dts:464.26-504.5: Warning (pci_bridge): 
> > /plb/pciex@d00000000: node name is not "pci" or "pcie"
> > ../../pc-bios/canyonlands.dts:506.26-546.5: Warning (pci_bridge): 
> > /plb/pciex@d20000000: node name is not "pci" or "pcie"
> > pc-bios/canyonlands.dtb: Warning (unit_address_format): Failed prerequisite 
> > 'pci_bridge'
> > pc-bios/canyonlands.dtb: Warning (pci_device_reg): Failed prerequisite 
> > 'pci_bridge'
> > pc-bios/canyonlands.dtb: Warning (pci_device_bus_num): Failed prerequisite 
> > 'pci_bridge'
> > ../../pc-bios/canyonlands.dts:268.14-289.7: Warning 
> > (avoid_unnecessary_addr_size): /plb/opb/ebc/ndfc@3,0: unnecessary 
> > #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" 
> > property
>
> This smells like something which has been here forever and no one noticed
> because the compile only happens when updating these files, ie, almost
> never.
>
> So, "don't blame the messenger" :)

I was about to ask, since when but probably nobody knows then. AFAIR I had 
no such errors for the canyonlands one when I've added it but that was 
quite some years ago and things in dtc for example could have changed so 
it now gives these warnings.

The dts files come from Linux so maybe it's fixed there but not sure if 
updating these would generate different dtb that the guests might not like 
as both these machines and guests running on them are quite old. So maybe 
it's safer to ignore the warnings? On the other hand, maybe this dtb is 
only used when booting Linux with -kernel, otherwise the u-boot firmware 
will generate it so updating it may not affect most guests anyway. I think 
Guenter Roeck (cc'd) used this for testing Linux kernels so maybe he has 
some more info or insight. This may not help much but that's all I can add 
to this.

Regards,
BALATON Zoltan