Re: [PATCH 2/4] hw/cpu: Call object_class_is_abstract() once in cpu_class_by_name()

[Richard Henderson]

On 9/8/23 04:22, Philippe Mathieu-Daudé wrote:
> Let CPUClass::class_by_name() handlers to return abstract classes,
> and filter them once in the public cpu_class_by_name() method.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   include/hw/core/cpu.h  |  7 ++++---
>   hw/core/cpu-common.c   | 14 +++++++++++---
>   target/arm/cpu.c       |  3 +--
>   target/avr/cpu.c       |  3 +--
>   target/cris/cpu.c      |  3 +--
>   target/hexagon/cpu.c   |  3 +--
>   target/loongarch/cpu.c |  3 +--
>   target/m68k/cpu.c      |  3 +--
>   target/openrisc/cpu.c  |  3 +--
>   target/riscv/cpu.c     |  3 +--
>   target/rx/cpu.c        |  6 +-----
>   target/sh4/cpu.c       |  3 ---
>   target/tricore/cpu.c   |  3 +--
>   target/xtensa/cpu.c    |  3 +--
>   14 files changed, 26 insertions(+), 34 deletions(-)

Missed the cleanup for alpha, which you introduced in patch 1.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~