qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 12/24] tcg: Rename cpu_env to tcg_env


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 12/24] tcg: Rename cpu_env to tcg_env
Date: Thu, 14 Sep 2023 17:30:57 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0

On 14/9/23 08:10, Philippe Mathieu-Daudé wrote:
On 14/9/23 04:44, Richard Henderson wrote:
Allow the name 'cpu_env' to be used for something else.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  include/tcg/tcg.h                             |    2 +-
  target/arm/tcg/translate-a32.h                |    2 +-
  target/arm/tcg/translate-a64.h                |    4 +-
  target/arm/tcg/translate.h                    |   16 +-
  target/hexagon/gen_tcg.h                      |  120 +-
  target/hexagon/gen_tcg_hvx.h                  |   20 +-
  target/hexagon/macros.h                       |    8 +-
  target/mips/tcg/translate.h                   |    6 +-
  accel/tcg/translator.c                        |    8 +-
  target/alpha/translate.c                      |  142 +-
  target/arm/tcg/translate-a64.c                |  374 ++---
  target/arm/tcg/translate-m-nocp.c             |   24 +-
  target/arm/tcg/translate-mve.c                |   52 +-
  target/arm/tcg/translate-neon.c               |   78 +-
  target/arm/tcg/translate-sme.c                |    8 +-
  target/arm/tcg/translate-sve.c                |  172 +--
  target/arm/tcg/translate-vfp.c                |   56 +-
  target/arm/tcg/translate.c                    |  228 +--
  target/avr/translate.c                        |   64 +-
  target/cris/translate.c                       |   68 +-
  target/hexagon/genptr.c                       |   36 +-
  target/hexagon/idef-parser/parser-helpers.c   |    2 +-
  target/hexagon/translate.c                    |   48 +-
  target/hppa/translate.c                       |  144 +-
  target/i386/tcg/translate.c                   |  580 ++++----
  target/loongarch/translate.c                  |   18 +-
  target/m68k/translate.c                       |  302 ++--
  target/microblaze/translate.c                 |   50 +-
  target/mips/tcg/lcsr_translate.c              |    6 +-
  target/mips/tcg/msa_translate.c               |   34 +-
  target/mips/tcg/mxu_translate.c               |    4 +-
  target/mips/tcg/translate.c                   | 1284 ++++++++---------
  target/mips/tcg/vr54xx_translate.c            |    2 +-
  target/nios2/translate.c                      |   48 +-
  target/openrisc/translate.c                   |   84 +-
  target/ppc/translate.c                        |  362 ++---
  target/riscv/translate.c                      |   50 +-
  target/rx/translate.c                         |   56 +-
  target/s390x/tcg/translate.c                  |  424 +++---
  target/sh4/translate.c                        |  124 +-
  target/sparc/translate.c                      |  328 ++---
  target/tricore/translate.c                    |  220 +--
  target/xtensa/translate.c                     |  188 +--
  tcg/tcg-op-gvec.c                             |  288 ++--
  tcg/tcg-op-ldst.c                             |   22 +-
  tcg/tcg-op.c                                  |    2 +-
  tcg/tcg.c                                     |    4 +-
  target/cris/translate_v10.c.inc               |   28 +-
  target/i386/tcg/decode-new.c.inc              |    2 +-
  target/i386/tcg/emit.c.inc                    |  262 ++--
  .../loongarch/insn_trans/trans_atomic.c.inc   |    4 +-
  .../loongarch/insn_trans/trans_branch.c.inc   |    2 +-
  target/loongarch/insn_trans/trans_extra.c.inc |   10 +-
  .../loongarch/insn_trans/trans_farith.c.inc   |    6 +-
  target/loongarch/insn_trans/trans_fcmp.c.inc  |    8 +-
  .../loongarch/insn_trans/trans_fmemory.c.inc  |    8 +-
  target/loongarch/insn_trans/trans_fmov.c.inc  |   20 +-
  target/loongarch/insn_trans/trans_lsx.c.inc   |   44 +-
  .../loongarch/insn_trans/trans_memory.c.inc   |    8 +-
  .../insn_trans/trans_privileged.c.inc         |   52 +-
  target/mips/tcg/micromips_translate.c.inc     |   12 +-
  target/mips/tcg/nanomips_translate.c.inc      |  200 +--
  target/ppc/power8-pmu-regs.c.inc              |    8 +-
  target/ppc/translate/branch-impl.c.inc        |    2 +-
  target/ppc/translate/dfp-impl.c.inc           |   22 +-
  target/ppc/translate/fixedpoint-impl.c.inc    |    2 +-
  target/ppc/translate/fp-impl.c.inc            |   50 +-
  .../ppc/translate/processor-ctrl-impl.c.inc   |    8 +-
  target/ppc/translate/spe-impl.c.inc           |   30 +-
  target/ppc/translate/storage-ctrl-impl.c.inc  |   26 +-
  target/ppc/translate/vmx-impl.c.inc           |   34 +-
  target/ppc/translate/vsx-impl.c.inc           |   54 +-
  .../riscv/insn_trans/trans_privileged.c.inc   |    8 +-
  target/riscv/insn_trans/trans_rvbf16.c.inc    |   10 +-
  target/riscv/insn_trans/trans_rvd.c.inc       |   48 +-
  target/riscv/insn_trans/trans_rvf.c.inc       |   46 +-
  target/riscv/insn_trans/trans_rvh.c.inc       |    8 +-
  target/riscv/insn_trans/trans_rvi.c.inc       |   16 +-
  target/riscv/insn_trans/trans_rvm.c.inc       |   16 +-
  target/riscv/insn_trans/trans_rvv.c.inc       |  130 +-
  target/riscv/insn_trans/trans_rvvk.c.inc      |   30 +-
  target/riscv/insn_trans/trans_rvzce.c.inc     |    2 +-
  target/riscv/insn_trans/trans_rvzfa.c.inc     |   38 +-
  target/riscv/insn_trans/trans_rvzfh.c.inc     |   54 +-
  target/riscv/insn_trans/trans_rvzicbo.c.inc   |    8 +-
  target/riscv/insn_trans/trans_svinval.c.inc   |    6 +-
  target/riscv/insn_trans/trans_xthead.c.inc    |    2 +-
  target/s390x/tcg/translate_vx.c.inc           |  104 +-
  target/hexagon/README                         |   10 +-
  target/hexagon/gen_tcg_funcs.py               |   16 +-
  90 files changed, 3808 insertions(+), 3808 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Missing:

-- >8 --
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
index 5c13615112..985c980c92 100644
--- a/accel/tcg/plugin-gen.c
+++ b/accel/tcg/plugin-gen.c
@@ -104,7 +104,7 @@ static void gen_empty_udata_cb(void)
     TCGv_ptr udata = tcg_temp_ebb_new_ptr();

     tcg_gen_movi_ptr(udata, 0);
-    tcg_gen_ld_i32(cpu_index, cpu_env,
+    tcg_gen_ld_i32(cpu_index, tcg_env,
-offsetof(ArchCPU, env) + offsetof(CPUState, cpu_index));
     gen_helper_plugin_vcpu_udata_cb(cpu_index, udata);

@@ -138,7 +138,7 @@ static void gen_empty_mem_cb(TCGv_i64 addr, uint32_t info)

     tcg_gen_movi_i32(meminfo, info);
     tcg_gen_movi_ptr(udata, 0);
-    tcg_gen_ld_i32(cpu_index, cpu_env,
+    tcg_gen_ld_i32(cpu_index, tcg_env,
-offsetof(ArchCPU, env) + offsetof(CPUState, cpu_index));

     gen_helper_plugin_vcpu_mem_cb(cpu_index, meminfo, addr, udata);
@@ -157,7 +157,7 @@ static void gen_empty_mem_helper(void)
     TCGv_ptr ptr = tcg_temp_ebb_new_ptr();

     tcg_gen_movi_ptr(ptr, 0);
-    tcg_gen_st_ptr(ptr, cpu_env, offsetof(CPUState, plugin_mem_cbs) -
+    tcg_gen_st_ptr(ptr, tcg_env, offsetof(CPUState, plugin_mem_cbs) -
                                  offsetof(ArchCPU, env));
     tcg_temp_free_ptr(ptr);
 }
@@ -581,7 +581,7 @@ void plugin_gen_disable_mem_helpers(void)
     if (!tcg_ctx->plugin_tb->mem_helper) {
         return;
     }
-    tcg_gen_st_ptr(tcg_constant_ptr(NULL), cpu_env,
+    tcg_gen_st_ptr(tcg_constant_ptr(NULL), tcg_env,
offsetof(CPUState, plugin_mem_cbs) - offsetof(ArchCPU, env));
 }

---




reply via email to

[Prev in Thread] Current Thread [Next in Thread]