[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/1] hw/timer/sse-timer: Add CNTFRQ reset property
From: |
Joe Komlodi |
Subject: |
[PATCH 1/1] hw/timer/sse-timer: Add CNTFRQ reset property |
Date: |
Thu, 14 Sep 2023 22:42:10 +0000 |
This can have a non-zero reset value, and cause the kernel to complain
about a CNTFRQ mismatch if TF-A (or firmware in general) does not
initialize it (because it expects the value to be non-zero out of
reset).
To fix this, we'll just add an object property that people can use to
initialize the CNTFRQ reset value.
Signed-off-by: Joe Komlodi <komlodi@google.com>
---
hw/timer/sse-timer.c | 4 +++-
include/hw/timer/sse-timer.h | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/timer/sse-timer.c b/hw/timer/sse-timer.c
index e92e83747d..a727f05bac 100644
--- a/hw/timer/sse-timer.c
+++ b/hw/timer/sse-timer.c
@@ -376,7 +376,7 @@ static void sse_timer_reset(DeviceState *dev)
trace_sse_timer_reset();
timer_del(&s->timer);
- s->cntfrq = 0;
+ s->cntfrq = s->cntfrq_reset;
s->cntp_ctl = 0;
s->cntp_cval = 0;
s->cntp_aival = 0;
@@ -430,6 +430,7 @@ static const VMStateDescription sse_timer_vmstate = {
.minimum_version_id = 1,
.fields = (VMStateField[]) {
VMSTATE_TIMER(timer, SSETimer),
+ VMSTATE_UINT32(cntfrq_reset, SSETimer),
VMSTATE_UINT32(cntfrq, SSETimer),
VMSTATE_UINT32(cntp_ctl, SSETimer),
VMSTATE_UINT64(cntp_cval, SSETimer),
@@ -442,6 +443,7 @@ static const VMStateDescription sse_timer_vmstate = {
static Property sse_timer_properties[] = {
DEFINE_PROP_LINK("counter", SSETimer, counter, TYPE_SSE_COUNTER,
SSECounter *),
+ DEFINE_PROP_UINT32("cntfrq-reset", SSETimer, cntfrq_reset, 0),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/include/hw/timer/sse-timer.h b/include/hw/timer/sse-timer.h
index 265ad32400..ad84c24940 100644
--- a/include/hw/timer/sse-timer.h
+++ b/include/hw/timer/sse-timer.h
@@ -43,6 +43,8 @@ struct SSETimer {
QEMUTimer timer;
Notifier counter_notifier;
+ uint32_t cntfrq_reset;
+
uint32_t cntfrq;
uint32_t cntp_ctl;
uint64_t cntp_cval;
--
2.42.0.459.ge4e396fd5e-goog