Re: [PATCH v3 3/3] linux-user/syscall.c: do_ppoll: eliminate large alloca

[Michael Tokarev]

14.09.2023 14:07, Daniel P. Berrangé wrote:
..

> > > > This can be dropped with g_autofree usage
> > >
> > > Yes, I know this, - this was deliberate choice.
> > > Personally I'm just too used to old-school explicit resource deallocations.
> > > Here, there's a single place where everything gets freed, so there's little
> > > reason to use fancy modern automatic deallocations. To my taste anyway.

> I prefer auto-free, but I'm fine with this commit either way, so

After thinking about it more.  Once these automatic helpers such as
g_autofree pointers slip into peoples minds, there's much less attention
being paid for freeing resources.   So I'll go with the autofree variant,
without explicit free.

>    Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Thank you for the review!

/mjt