Re: [PATCH v2 04/10] Introduce the CPU address space destruction function

[David Hildenbrand]

On 15.09.23 16:19, Philippe Mathieu-Daudé wrote:
> On 15/9/23 10:07, David Hildenbrand wrote:
>
> > The CPU implementation end up call qemu_init_vcpu() in their realize
> > function; there should be something like qemu_destroy_vcpu() on the
> > unrealize path that takes care of undoing any cpu_address_space_init().
> >
> > We seem to have cpu_common_unrealizefn()->cpu_exec_unrealizefn() but
> > that doesn't take care of address spaces.
> >
> > Also, in qemu_init_vcpu() we do a cpus_accel->create_vcpu_thread(cpu).
> > I'm, curious if we destroy that thread somehow.
>
> Implicitly in cpu_remove_sync().

Ah, indeed. there is the qemu_thread_join().

--
Cheers,

David / dhildenb