Re: [PATCH 06/11] exec: Rename cpu.c -> cpu-target.c

[Philippe Mathieu-Daudé]

On 15/9/23 16:19, Anton Johansson wrote:
> On 14/09/23, Philippe Mathieu-Daudé wrote:
> > We have exec/cpu code split in 2 files for target agnostic
> > ("common") and specific. Rename 'cpu.c' which is target
> > specific using the '-target' suffix. Update MAINTAINERS.
> > Remove the 's from 'cpus-common.c' to match the API cpu_foo()
> > functions.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   MAINTAINERS                   | 4 ++--
> >   meson.build                   | 4 ++--
> >   cpus-common.c => cpu-common.c | 0
> >   cpu.c => cpu-target.c         | 0
> >   4 files changed, 4 insertions(+), 4 deletions(-)
> >   rename cpus-common.c => cpu-common.c (100%)
> >   rename cpu.c => cpu-target.c (100%)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 00562f924f..12261d8eaf 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -139,7 +139,8 @@ R: Paolo Bonzini <pbonzini@redhat.com>
> >   S: Maintained
> >   F: softmmu/cpus.c
> >   F: softmmu/watchpoint.c
> > -F: cpus-common.c
> > +F: cpu-common.c
> > +F: cpu-target.c

The renamed file is here ^

> >   F: page-vary.c
> >   F: page-vary-common.c
> >   F: accel/tcg/
> > @@ -1772,7 +1773,6 @@ M: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> >   R: Philippe Mathieu-Daudé <philmd@linaro.org>
> >   R: Yanan Wang <wangyanan55@huawei.com>
> >   S: Supported
> > -F: cpu.c
> Was the maintainer switch intentional?

(yes, see earlier)

> Either way,
> Reviewed-by: Anton Johansson <anjo@rev.ng>

Thanks!