Re: [PATCH 4/4] hw/cxl: Line length reductions

[Jonathan Cameron]

On Fri, 15 Sep 2023 18:01:30 +0100
Jonathan Cameron via <qemu-devel@nongnu.org> wrote:

> On Thu, 14 Sep 2023 15:57:55 +0300
> Michael Tokarev <mjt@tls.msk.ru> wrote:
> 
> > 13.09.2023 18:05, Jonathan Cameron via wrote:  
> > > Michael Tsirkin observed that there were some unnecessarily
> > > long lines in the CXL code in a recent review.
> > > This patch is intended to rectify that where it does not
> > > hurt readability.    
> > 
> > Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
> > 
> > This whole series can be picked up into trivial-patches tree
> > (whcih is getting ready to be pushed to master).  
> 
> I've reworked patch 2 as you made some good points about the
> changes making unclear code even more unclear.
> 
> Also, I have this on top of a series that touches the same bit
> of code.  For me landing that is more important than this, hence
> the ordering of the series.
> 
> Hopefully Michael Tsirkin will pick up v2 along with the
> other series, or whcih can take this in the future once the
> dependency is in place.

You that is.  I briefly imagined there was someone using the
tag whcih :) 

Friday evening is my excuse...

Too much code review today it seems.

Jonathan

> 
> Jonathan
> 
> 
> > 
> > /mjt
> > 
> >   
> 
> 
>