Re: [PATCH v2 3/3] softmmu: Introduce cpu_address_space_sync

[Richard Henderson]

On 9/15/23 09:57, Philippe Mathieu-Daudé wrote:
> On 15/9/23 18:32, Richard Henderson wrote:
> > Synchronously check and update the address space for the
> > current cpu for any slow path access.
> >
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1866
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   include/exec/memory.h |  6 ++++++
> >   accel/tcg/cputlb.c    |  2 ++
> >   softmmu/physmem.c     | 20 ++++++++++++++++++++
> >   3 files changed, 28 insertions(+)
> >
> > diff --git a/include/exec/memory.h b/include/exec/memory.h
> > index 68284428f8..7ec842076f 100644
> > --- a/include/exec/memory.h
> > +++ b/include/exec/memory.h
> > @@ -2780,6 +2780,12 @@ void address_space_cache_destroy(MemoryRegionCache 
> > *cache);
> >   IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr,
> >                                               bool is_write, MemTxAttrs attrs);
> > +/*
> > + * Ensure all cpu address spaces are up-to-date.
> > + * Return true if changes made and tlb flushed.
>
> No return value, stale comment?

Whoops, yes.

r~