[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 21/39] accel/tcg: Remove env_tlb()
From: |
Richard Henderson |
Subject: |
[PATCH v3 21/39] accel/tcg: Remove env_tlb() |
Date: |
Sat, 16 Sep 2023 14:41:05 -0700 |
From: Anton Johansson <anjo@rev.ng>
The function is no longer used to access the TLB,
and has been replaced by cpu->neg.tlb.
Signed-off-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230912153428.17816-9-anjo@rev.ng>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
[rth: Merge comment update patch]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/cpu-all.h | 11 -----------
tcg/aarch64/tcg-target.c.inc | 2 +-
tcg/arm/tcg-target.c.inc | 2 +-
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index af9516654a..b37715c27d 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -451,15 +451,4 @@ static inline CPUState *env_cpu(CPUArchState *env)
return (void *)env - sizeof(CPUState);
}
-/**
- * env_tlb(env)
- * @env: The architecture environment
- *
- * Return the CPUTLB state associated with the environment.
- */
-static inline CPUTLB *env_tlb(CPUArchState *env)
-{
- return &env_cpu(env)->neg.tlb;
-}
-
#endif /* CPU_ALL_H */
diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
index 06ea3c7652..69f2daf2c2 100644
--- a/tcg/aarch64/tcg-target.c.inc
+++ b/tcg/aarch64/tcg-target.c.inc
@@ -1679,7 +1679,7 @@ static TCGLabelQemuLdst *prepare_host_addr(TCGContext *s,
HostAddress *h,
mask_type = (s->page_bits + s->tlb_dyn_max_bits > 32
? TCG_TYPE_I64 : TCG_TYPE_I32);
- /* Load env_tlb(env)->f[mmu_idx].{mask,table} into {tmp0,tmp1}. */
+ /* Load cpu->neg.tlb.f[mmu_idx].{mask,table} into {tmp0,tmp1}. */
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, mask) != 0);
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, table) != 8);
tcg_out_insn(s, 3314, LDP, TCG_REG_TMP0, TCG_REG_TMP1, TCG_AREG0,
diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
index b1d56362a7..a2f60106af 100644
--- a/tcg/arm/tcg-target.c.inc
+++ b/tcg/arm/tcg-target.c.inc
@@ -1420,7 +1420,7 @@ static TCGLabelQemuLdst *prepare_host_addr(TCGContext *s,
HostAddress *h,
ldst->addrlo_reg = addrlo;
ldst->addrhi_reg = addrhi;
- /* Load env_tlb(env)->f[mmu_idx].{mask,table} into {r0,r1}. */
+ /* Load cpu->neg.tlb.f[mmu_idx].{mask,table} into {r0,r1}. */
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, mask) != 0);
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, table) != 4);
tcg_out_ldrd_8(s, COND_AL, TCG_REG_R0, TCG_AREG0, fast_off);
--
2.34.1
- [PATCH v3 10/39] accel/tcg: Remove cpu_neg(), (continued)
- [PATCH v3 10/39] accel/tcg: Remove cpu_neg(), Richard Henderson, 2023/09/16
- [PATCH v3 14/39] accel/tcg: Remove env_neg(), Richard Henderson, 2023/09/16
- [PATCH v3 15/39] tcg: Remove TCGContext.tlb_fast_offset, Richard Henderson, 2023/09/16
- [PATCH v3 17/39] accel/tcg: Modify probe_access_internal() to use CPUState, Richard Henderson, 2023/09/16
- [PATCH v3 16/39] accel/tcg: Modify tlb_*() to use CPUState, Richard Henderson, 2023/09/16
- [PATCH v3 11/39] tcg: Rename cpu_env to tcg_env, Richard Henderson, 2023/09/16
- [PATCH v3 12/39] accel/tcg: Replace CPUState.env_ptr with cpu_env(), Richard Henderson, 2023/09/16
- [PATCH v3 13/39] accel/tcg: Remove cpu_set_cpustate_pointers, Richard Henderson, 2023/09/16
- [PATCH v3 21/39] accel/tcg: Remove env_tlb(),
Richard Henderson <=
- [PATCH v3 18/39] accel/tcg: Modify memory access functions to use CPUState, Richard Henderson, 2023/09/16
- [PATCH v3 28/39] accel: Rename accel-common.c -> accel-target.c, Richard Henderson, 2023/09/16
- [PATCH v3 24/39] exec: Make EXCP_FOO definitions target agnostic, Richard Henderson, 2023/09/16
- [PATCH v3 26/39] accel/tcg: Restrict dump_exec_info() declaration, Richard Henderson, 2023/09/16
- [PATCH v3 29/39] exec: Rename cpu.c -> cpu-target.c, Richard Henderson, 2023/09/16
- [PATCH v3 33/39] accel/tcg: Make icount.o a target agnostic unit, Richard Henderson, 2023/09/16
- [PATCH v3 38/39] accel/tcg: Have tcg_exec_realizefn() return a boolean, Richard Henderson, 2023/09/16
- [PATCH v3 19/39] accel/tcg: Modify atomic_mmu_lookup() to use CPUState, Richard Henderson, 2023/09/16
- [PATCH v3 30/39] exec: Rename target specific page-vary.c -> page-vary-target.c, Richard Henderson, 2023/09/16