[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 34/39] accel/tcg: Make cpu-exec-common.c a target agnostic uni
From: |
Richard Henderson |
Subject: |
[PATCH v3 34/39] accel/tcg: Make cpu-exec-common.c a target agnostic unit |
Date: |
Sat, 16 Sep 2023 14:41:18 -0700 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
cpu_in_serial_context() is not target specific,
move it declaration to "internal-common.h" (which
we include in the 4 source files modified).
Remove the unused "exec/exec-all.h" header from
cpu-exec-common.c. There is no more target specific
code in this file: make it target agnostic.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230914185718.76241-12-philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/internal-common.h | 11 +++++++++++
accel/tcg/internal-target.h | 9 ---------
accel/tcg/cpu-exec-common.c | 3 +--
accel/tcg/cputlb.c | 1 +
accel/tcg/tb-maint.c | 1 +
accel/tcg/user-exec.c | 1 +
accel/tcg/meson.build | 4 +++-
7 files changed, 18 insertions(+), 12 deletions(-)
diff --git a/accel/tcg/internal-common.h b/accel/tcg/internal-common.h
index 5d5247442e..3b2277e6e9 100644
--- a/accel/tcg/internal-common.h
+++ b/accel/tcg/internal-common.h
@@ -9,9 +9,20 @@
#ifndef ACCEL_TCG_INTERNAL_COMMON_H
#define ACCEL_TCG_INTERNAL_COMMON_H
+#include "exec/translation-block.h"
+
extern int64_t max_delay;
extern int64_t max_advance;
void dump_exec_info(GString *buf);
+/*
+ * Return true if CS is not running in parallel with other cpus, either
+ * because there are no other cpus or we are within an exclusive context.
+ */
+static inline bool cpu_in_serial_context(CPUState *cs)
+{
+ return !(cs->tcg_cflags & CF_PARALLEL) || cpu_in_exclusive_context(cs);
+}
+
#endif
diff --git a/accel/tcg/internal-target.h b/accel/tcg/internal-target.h
index f9eec1ce28..932bbe4b63 100644
--- a/accel/tcg/internal-target.h
+++ b/accel/tcg/internal-target.h
@@ -90,15 +90,6 @@ static inline vaddr log_pc(CPUState *cpu, const
TranslationBlock *tb)
}
}
-/*
- * Return true if CS is not running in parallel with other cpus, either
- * because there are no other cpus or we are within an exclusive context.
- */
-static inline bool cpu_in_serial_context(CPUState *cs)
-{
- return !(cs->tcg_cflags & CF_PARALLEL) || cpu_in_exclusive_context(cs);
-}
-
extern bool one_insn_per_tb;
/**
diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c
index 55980417b4..b6cc387482 100644
--- a/accel/tcg/cpu-exec-common.c
+++ b/accel/tcg/cpu-exec-common.c
@@ -20,9 +20,8 @@
#include "qemu/osdep.h"
#include "sysemu/cpus.h"
#include "sysemu/tcg.h"
-#include "exec/exec-all.h"
#include "qemu/plugin.h"
-#include "internal-target.h"
+#include "internal-common.h"
bool tcg_allowed;
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index df20bf4034..b8c5e345b8 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -35,6 +35,7 @@
#include "exec/translate-all.h"
#include "trace.h"
#include "tb-hash.h"
+#include "internal-common.h"
#include "internal-target.h"
#ifdef CONFIG_PLUGIN
#include "qemu/plugin-memory.h"
diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index 85cf51445d..b194f8f065 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -29,6 +29,7 @@
#include "tcg/tcg.h"
#include "tb-hash.h"
#include "tb-context.h"
+#include "internal-common.h"
#include "internal-target.h"
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index f925dd0305..5bf2761bf4 100644
--- a/accel/tcg/user-exec.c
+++ b/accel/tcg/user-exec.c
@@ -29,6 +29,7 @@
#include "qemu/atomic128.h"
#include "trace/trace-root.h"
#include "tcg/tcg-ldst.h"
+#include "internal-common.h"
#include "internal-target.h"
__thread uintptr_t helper_retaddr;
diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build
index 4633a34d28..8783edd06e 100644
--- a/accel/tcg/meson.build
+++ b/accel/tcg/meson.build
@@ -1,7 +1,9 @@
tcg_ss = ss.source_set()
+common_ss.add(when: 'CONFIG_TCG', if_true: files(
+ 'cpu-exec-common.c',
+))
tcg_ss.add(files(
'tcg-all.c',
- 'cpu-exec-common.c',
'cpu-exec.c',
'tb-maint.c',
'tcg-runtime-gvec.c',
--
2.34.1
- [PATCH v3 28/39] accel: Rename accel-common.c -> accel-target.c, (continued)
- [PATCH v3 28/39] accel: Rename accel-common.c -> accel-target.c, Richard Henderson, 2023/09/16
- [PATCH v3 24/39] exec: Make EXCP_FOO definitions target agnostic, Richard Henderson, 2023/09/16
- [PATCH v3 26/39] accel/tcg: Restrict dump_exec_info() declaration, Richard Henderson, 2023/09/16
- [PATCH v3 29/39] exec: Rename cpu.c -> cpu-target.c, Richard Henderson, 2023/09/16
- [PATCH v3 33/39] accel/tcg: Make icount.o a target agnostic unit, Richard Henderson, 2023/09/16
- [PATCH v3 38/39] accel/tcg: Have tcg_exec_realizefn() return a boolean, Richard Henderson, 2023/09/16
- [PATCH v3 19/39] accel/tcg: Modify atomic_mmu_lookup() to use CPUState, Richard Henderson, 2023/09/16
- [PATCH v3 30/39] exec: Rename target specific page-vary.c -> page-vary-target.c, Richard Henderson, 2023/09/16
- [PATCH v3 32/39] accel/tcg: Make monitor.c a target-agnostic unit, Richard Henderson, 2023/09/16
- [PATCH v3 35/39] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize(), Richard Henderson, 2023/09/16
- [PATCH v3 34/39] accel/tcg: Make cpu-exec-common.c a target agnostic unit,
Richard Henderson <=
- [PATCH v3 20/39] accel/tcg: Use CPUState in atomicity helpers, Richard Henderson, 2023/09/16
- [PATCH v3 27/39] accel: Make accel-blocker.o target agnostic, Richard Henderson, 2023/09/16
- [PATCH v3 31/39] accel/tcg: Rename target-specific 'internal.h' -> 'internal-target.h', Richard Henderson, 2023/09/16
- [PATCH v3 36/39] accel: Introduce accel_cpu_unrealize() stub, Richard Henderson, 2023/09/16
- [PATCH v3 22/39] accel/tcg: Unify user and softmmu do_[st|ld]*_mmu(), Richard Henderson, 2023/09/16
- [PATCH v3 23/39] accel/tcg: move ld/st helpers to ldst_common.c.inc, Richard Henderson, 2023/09/16
- [PATCH v3 25/39] exec: Move cpu_loop_foo() target agnostic functions to 'cpu-common.h', Richard Henderson, 2023/09/16
- [PATCH v3 37/39] accel: Declare AccelClass::[un]realize_cpu() handlers, Richard Henderson, 2023/09/16
- [PATCH v3 39/39] accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG, Richard Henderson, 2023/09/16