[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 06/52] migration/rdma: Clean up two more harmless signed vs. unsi
From: |
Markus Armbruster |
Subject: |
[PATCH 06/52] migration/rdma: Clean up two more harmless signed vs. unsigned issues |
Date: |
Mon, 18 Sep 2023 16:41:20 +0200 |
qemu_rdma_exchange_get_response() compares int parameter @expecting
with uint32_t head->type. Actual arguments are non-negative
enumeration constants, RDMAControlHeader uint32_t member type, or
qemu_rdma_exchange_recv() int parameter expecting. Actual arguments
for the latter are non-negative enumeration constants. Change both
parameters to uint32_t.
In qio_channel_rdma_readv(), loop control variable @i is ssize_t, and
counts from 0 up to @niov, which is size_t. Change @i to size_t.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
migration/rdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 4328610a4c..e3b8d0506c 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1801,7 +1801,7 @@ static int qemu_rdma_post_recv_control(RDMAContext *rdma,
int idx)
* Block and wait for a RECV control channel message to arrive.
*/
static int qemu_rdma_exchange_get_response(RDMAContext *rdma,
- RDMAControlHeader *head, int expecting, int idx)
+ RDMAControlHeader *head, uint32_t expecting, int idx)
{
uint32_t byte_len;
int ret = qemu_rdma_block_for_wrid(rdma, RDMA_WRID_RECV_CONTROL + idx,
@@ -1959,7 +1959,7 @@ static int qemu_rdma_exchange_send(RDMAContext *rdma,
RDMAControlHeader *head,
* control-channel message.
*/
static int qemu_rdma_exchange_recv(RDMAContext *rdma, RDMAControlHeader *head,
- int expecting)
+ uint32_t expecting)
{
RDMAControlHeader ready = {
.len = 0,
@@ -2851,7 +2851,7 @@ static ssize_t qio_channel_rdma_readv(QIOChannel *ioc,
RDMAContext *rdma;
RDMAControlHeader head;
int ret = 0;
- ssize_t i;
+ size_t i;
size_t done = 0;
RCU_READ_LOCK_GUARD();
--
2.41.0
- [PATCH 02/52] migration/rdma: Clean up qemu_rdma_data_init()'s return type, (continued)
- [PATCH 02/52] migration/rdma: Clean up qemu_rdma_data_init()'s return type, Markus Armbruster, 2023/09/18
- [PATCH 27/52] migration/rdma: Drop superfluous assignments to @ret, Markus Armbruster, 2023/09/18
- [PATCH 20/52] migration/rdma: Drop dead qemu_rdma_data_init() code for !@host_port, Markus Armbruster, 2023/09/18
- [PATCH 46/52] migration/rdma: Silence qemu_rdma_reg_control(), Markus Armbruster, 2023/09/18
- [PATCH 06/52] migration/rdma: Clean up two more harmless signed vs. unsigned issues,
Markus Armbruster <=
- [PATCH 32/52] migration/rdma: Fix error handling around rdma_getaddrinfo(), Markus Armbruster, 2023/09/18
- [PATCH 11/52] migration/rdma: Drop rdma_add_block() error handling, Markus Armbruster, 2023/09/18
- [PATCH 34/52] migration/rdma: Convert qemu_rdma_exchange_recv() to Error, Markus Armbruster, 2023/09/18