[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] hw/mem/cxl_type3: Add missing copyright and license noti
From: |
Dave Jiang |
Subject: |
Re: [PATCH 2/3] hw/mem/cxl_type3: Add missing copyright and license notice |
Date: |
Mon, 18 Sep 2023 10:26:19 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Betterbird/102.13.0 |
On 9/18/23 10:00, Jonathan Cameron wrote:
> On Mon, 18 Sep 2023 17:31:38 +0100
> Peter Maydell <peter.maydell@linaro.org> wrote:
>
>> On Mon, 18 Sept 2023 at 16:04, Jonathan Cameron
>> <Jonathan.Cameron@huawei.com> wrote:
>>>
>>> This has been missing from the start. Assume it should match
>>> with cxl/cxl-component-utils.c as both were part of early
>>> postings from Ben.
>>
>> Sounds plausible -- is there an Intel person who could give us
>> an acked-by for this?
>>
>> (Ideally we wouldn't have let more gpl-2-only code into the
>> codebase without a rationale...)
>>
>
> I've +CC'd the kernel CXL maintainers from Intel a few of whom
> have also contributed some of the QEMU CXL code.
> Hopefully someone can ack.
I see that nvdimm.c from Intel is under LGPL 2.1. What is the typical license
this should be applied for QEMU?
>
>>> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> ---
>>> hw/mem/cxl_type3.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
>>> index c5855d4e7d..ad3f0f6a9d 100644
>>> --- a/hw/mem/cxl_type3.c
>>> +++ b/hw/mem/cxl_type3.c
>>> @@ -1,3 +1,12 @@
>>> +/*
>>> + * CXL Type 3 (memory expander) device
>>> + *
>>> + * Copyright(C) 2020 Intel Corporation.
>>> + *
>>> + * This work is licensed under the terms of the GNU GPL, version 2. See the
>>> + * COPYING file in the top-level directory.
>>> + */
>>> +
>>> #include "qemu/osdep.h"
>>> #include "qemu/units.h"
>>> #include "qemu/error-report.h"
>>
>> -- PMM
>>
>
- [PATCH 0/3] hw/cxl: Misc small fixes, Jonathan Cameron, 2023/09/18
- [PATCH 1/3] hw/cxl: Fix out of bound array access, Jonathan Cameron, 2023/09/18
- [PATCH 2/3] hw/mem/cxl_type3: Add missing copyright and license notice, Jonathan Cameron, 2023/09/18
- Re: [PATCH 2/3] hw/mem/cxl_type3: Add missing copyright and license notice, Dave Jiang, 2023/09/18
- Re: [PATCH 2/3] hw/mem/cxl_type3: Add missing copyright and license notice, Ira Weiny, 2023/09/18
- Re: [PATCH 2/3] hw/mem/cxl_type3: Add missing copyright and license notice, Daniel P . Berrangé, 2023/09/19
- Re: [PATCH 2/3] hw/mem/cxl_type3: Add missing copyright and license notice, Jonathan Cameron, 2023/09/19
Re: [PATCH 2/3] hw/mem/cxl_type3: Add missing copyright and license notice, Warner Losh, 2023/09/18
[PATCH 3/3] docs/cxl: Cleanout some more aarch64 examples., Jonathan Cameron, 2023/09/18