[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/22] parallels: return earler in fail_format branch in parallel
From: |
Denis V. Lunev |
Subject: |
[PATCH 05/22] parallels: return earler in fail_format branch in parallels_open() |
Date: |
Mon, 18 Sep 2023 20:00:43 +0200 |
We do not need to perform any deallocation/cleanup if wrong format is
detected.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index ae006e7fc7..12f38cf70b 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1232,7 +1232,8 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
fail_format:
error_setg(errp, "Image not in Parallels format");
- ret = -EINVAL;
+ return -EINVAL;
+
fail:
/*
* "s" object was allocated by g_malloc0 so we can safely
--
2.34.1
- [PATCH v2 00/22] implement discard operation for Parallels images, Denis V. Lunev, 2023/09/18
- [PATCH 03/22] parallels: fix memory leak in parallels_open(), Denis V. Lunev, 2023/09/18
- [PATCH 05/22] parallels: return earler in fail_format branch in parallels_open(),
Denis V. Lunev <=
- [PATCH 07/22] parallels: refactor path when we need to re-check image in parallels_open, Denis V. Lunev, 2023/09/18
- [PATCH 02/22] parallels: mark driver as supporting CBT, Denis V. Lunev, 2023/09/18
- [PATCH 06/22] parallels: return earlier from parallels_open() function on error, Denis V. Lunev, 2023/09/18
- [PATCH 04/22] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts, Denis V. Lunev, 2023/09/18
- [PATCH 08/22] parallels: create mark_used() helper which sets bit in used bitmap, Denis V. Lunev, 2023/09/18
- [PATCH 3/3] tests: extend test 131 to cover availability of the write-zeroes, Denis V. Lunev, 2023/09/18
- [PATCH 01/22] parallels: fix formatting in bdrv_parallels initialization, Denis V. Lunev, 2023/09/18
- [PATCH 18/22] parallels: improve readability of allocate_clusters, Denis V. Lunev, 2023/09/18