[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error |
Date: |
Tue, 19 Sep 2023 07:40:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On Thu, Aug 31, 2023 at 03:25:40PM +0200, Markus Armbruster wrote:
>> qemu_rdma_save_page() reports polling error with error_report(), then
>> succeeds anyway. This is because the variable holding the polling
>> status *shadows* the variable the function returns. The latter
>> remains zero.
>>
>> Broken since day one, and duplicated more recently.
>>
>> Fixes: 2da776db4846 (rdma: core logic)
>> Fixes: b390afd8c50b (migration/rdma: Fix out of order wrid)
>
> Alas, the curse of immutable git history preserving typos in commit
> subjects ;)
"wrid" is short for "work request ID", actually.
> The alternative of rewriting history and breaking SHA
> references is worse.
Rewriting master is a big no-no.
git-note can be used to correct the record, but it has its usability
issues.
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> migration/rdma.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks!