Re: [PATCH v2 05/18] ui/vc: console-vc requires PIXMAN

[Paolo Bonzini]

On 9/18/23 15:51, marcandre.lureau@redhat.com wrote:
>           return "vc:80Cx24C";
> +#else
> +        return "null";

Maybe return NULL and then add some heuristics in vl.c:

     const char *vc = qemu_display_get_vc(&dpy);
     if (nographic ||
         (!vc && !is_daemonized() && isatty(STDOUT_FILENO)) {
         ...
     } else {
        if (default_serial)
            add_device_config(DEV_SERIAL, vc ? vc : "null");
        if (default_parallel)
            add_device_config(DEV_PARALLEL, vc ? vc : "null");
        if (default_monitor && vc)
            monitor_parse(vc, "readline", false);
     }

This would use a muxed console on stdio if pixman is disabled.

Paolo