Re: [RFC PATCH v2 03/21] HostMem: Add private property and associate it with RAM_KVM_GMEM

[Xiaoyao Li]

On 9/19/2023 5:46 PM, Markus Armbruster wrote:
> Xiaoyao Li <xiaoyao.li@intel.com> writes:
>
> > From: Isaku Yamahata <isaku.yamahata@intel.com>
> >
> > Add a new property "private" to memory backends. When it's set to true,
> > it indicates the RAMblock of the backend also requires kvm gmem.
>
> Can you add a brief explanation why you need the property?

It provides a mechanism for user to specify whether the memory can serve 
as private memory (need request kvm gmem).

> > Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> > Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>
> [...]
>
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index fa3e88c8e6ab..d28c5403bc0f 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -605,6 +605,9 @@
> >   # @reserve: if true, reserve swap space (or huge pages) if applicable
> >   #     (default: true) (since 6.1)
> >   #
> > +# @private: if true, use KVM gmem private memory (default: false)
> > +#     (since 8.2)
> > +#
> >   # @size: size of the memory region in bytes
> >   #
> >   # @x-use-canonical-path-for-ramblock-id: if true, the canonical path
> > @@ -631,6 +634,7 @@
> >               '*prealloc-context': 'str',
> >               '*share': 'bool',
> >               '*reserve': 'bool',
> > +            '*private': 'bool',
> >               'size': 'size',
> >               '*x-use-canonical-path-for-ramblock-id': 'bool' } }