[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/7] block: Clean up local variable shadowing
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v2 6/7] block: Clean up local variable shadowing |
Date: |
Thu, 21 Sep 2023 10:33:54 +0200 |
Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Tracked down with -Wshadow=local.
> Clean up: delete inner declarations when they are actually redundant,
> else rename variables.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
- [PATCH v2 4/7] block/dirty-bitmap: Clean up local variable shadowing, (continued)
- [PATCH v2 4/7] block/dirty-bitmap: Clean up local variable shadowing, Markus Armbruster, 2023/09/20
- [PATCH v2 5/7] block/vdi: Clean up local variable shadowing, Markus Armbruster, 2023/09/20
- [PATCH v2 7/7] qobject atomics osdep: Make a few macros more hygienic, Markus Armbruster, 2023/09/20
- [PATCH v2 6/7] block: Clean up local variable shadowing, Markus Armbruster, 2023/09/20
- Re: [PATCH v2 6/7] block: Clean up local variable shadowing,
Kevin Wolf <=
- [PATCH v2 2/7] migration: Clean up local variable shadowing, Markus Armbruster, 2023/09/20