[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/10] Validate and test qapi examples
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 00/10] Validate and test qapi examples |
Date: |
Thu, 21 Sep 2023 13:21:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Hi,
>
> v2: https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg02383.html
>
> - Sorry Markus, I kept the two last 'fix example' patches as I don't
> fully remember how we should go with it.
That's fine.
I see two sane alternatives:
1. Add suitable elision syntax. Happy to discuss details, but I think
we should discuss my review of PATCH 10 before we complicate matters
further.
2. Decide we don't need elisions. Delete the ones we have. I'd like to
see an argument that the ones we have are not helpful enough to justfify
the effort to keep them.
> Not taking them but taking
> the generator would be bad as we would fail the build.
Understood.
[...]
- [PATCH v3 01/10] qapi: fix example of get-win32-socket command, (continued)
- [PATCH v3 01/10] qapi: fix example of get-win32-socket command, Victor Toso, 2023/09/19
- [PATCH v3 04/10] qapi: fix example of set-vcpu-dirty-limit command, Victor Toso, 2023/09/19
- [PATCH v3 06/10] qapi: fix example of NETDEV_STREAM_CONNECTED event, Victor Toso, 2023/09/19
- [PATCH v3 08/10] qapi: fix example of query-rocker-of-dpa-flows command, Victor Toso, 2023/09/19
- [PATCH v3 05/10] qapi: fix example of calc-dirty-rate command, Victor Toso, 2023/09/19
- [PATCH v3 07/10] qapi: fix example of query-blockstats command, Victor Toso, 2023/09/19
- [PATCH v3 03/10] qapi: fix example of cancel-vcpu-dirty-limit command, Victor Toso, 2023/09/19
- [PATCH v3 09/10] qapi: fix example of query-spice command, Victor Toso, 2023/09/19
- [PATCH v3 10/10] qapi: scripts: add a generator for qapi's examples, Victor Toso, 2023/09/19
- Re: [PATCH v3 00/10] Validate and test qapi examples,
Markus Armbruster <=