[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/12] audio: Require AudioState in AUD_add_capture
From: |
Paolo Bonzini |
Subject: |
[PULL 12/12] audio: Require AudioState in AUD_add_capture |
Date: |
Fri, 22 Sep 2023 11:31:25 +0200 |
From: Martin Kletzander <mkletzan@redhat.com>
Since all callers require a valid audiodev this function can now safely
abort in case of missing AudioState.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Message-ID:
<c6e87e678e914df0f59da2145c2753cdb4a16f63.1650874791.git.mkletzan@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
audio/audio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 666ef4237dd..d72e7db7fb9 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1854,8 +1854,9 @@ CaptureVoiceOut *AUD_add_capture(
struct capture_callback *cb;
if (!s) {
- dolog("Capturing without setting an audiodev is deprecated\n");
- s = audio_init(NULL, NULL);
+ error_setg(&error_abort,
+ "Capturing without setting an audiodev is not supported");
+ abort();
}
if (!audio_get_pdo_out(s->dev)->mixing_engine) {
--
2.41.0
- [PULL 01/12] target/i386: enumerate bit 56 of MSR_IA32_VMX_BASIC, (continued)
- [PULL 01/12] target/i386: enumerate bit 56 of MSR_IA32_VMX_BASIC, Paolo Bonzini, 2023/09/22
- [PULL 03/12] qemu/timer: Add host ticks function for RISC-V, Paolo Bonzini, 2023/09/22
- [PULL 04/12] audio: remove QEMU_AUDIO_* and -audio-help support, Paolo Bonzini, 2023/09/22
- [PULL 06/12] hw/audio: Simplify hda audio init, Paolo Bonzini, 2023/09/22
- [PULL 11/12] ui/vnc: Require audiodev= to enable audio, Paolo Bonzini, 2023/09/22
- [PULL 10/12] audio/spiceaudio: Fail initialisation when not using spice, Paolo Bonzini, 2023/09/22
- [PULL 07/12] hw/audio/lm4549: Add errp error reporting to init function, Paolo Bonzini, 2023/09/22
- [PULL 05/12] hw/input/tsc210x: Extract common init code into new function, Paolo Bonzini, 2023/09/22
- [PULL 08/12] hw/display/xlnx_dp.c: Add audiodev property, Paolo Bonzini, 2023/09/22
- [PULL 09/12] tests/qtest: Specify audiodev= and -audiodev, Paolo Bonzini, 2023/09/22
- [PULL 12/12] audio: Require AudioState in AUD_add_capture,
Paolo Bonzini <=