Re: Help wanted for enabling -Wshadow=local

[Markus Armbruster]

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Fri, Sep 22, 2023 at 04:03:27PM +0530, Ani Sinha wrote:
>> 
>> 
>> > On 22-Sep-2023, at 3:07 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> > 
>> > Devices
>> > -------
>> > ACPI/SMBIOS
>> > M: Michael S. Tsirkin <mst@redhat.com>
>> > M: Igor Mammedov <imammedo@redhat.com>
>> > R: Ani Sinha <anisinha@redhat.com>
>> >    hw/acpi/cpu_hotplug.c
>> >    hw/i386/acpi-build.c(*3*)
>> >    hw/smbios/smbios.c
>> 
>> I will look into this after enabling
>> 
>> diff --git a/meson.build b/meson.build
>> index 98e68ef0b1..9fc4c7ac9d 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -466,6 +466,9 @@ warn_flags = [
>>    '-Wno-tautological-type-limit-compare',
>>    '-Wno-psabi',
>>    '-Wno-gnu-variable-sized-type-not-at-end',
>> +  '-Wshadow=local',
>> +  '-Wno-error=shadow=local',
>> +  '-Wno-error=shadow=compatible-local',
>>  ]
>
>
> Am I right that one can equivalently do
> ./configure --disable-werror --extra-cflags='-Wshadow=local 
> -Wno-error=shadow=local -Wno-error=shadow=compatible-local'
> ?

Should do, although the --disable-werror is redundant with the
-Wno-error=...