[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 27/28] bsd-user: Implement rfork(2) system call.
From: |
Karim Taha |
Subject: |
[PATCH v5 27/28] bsd-user: Implement rfork(2) system call. |
Date: |
Mon, 25 Sep 2023 21:24:24 +0300 |
From: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/freebsd/os-proc.h | 39 +++++++++++++++++++++++++++++++++++
bsd-user/freebsd/os-syscall.c | 4 ++++
2 files changed, 43 insertions(+)
diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h
index 7b2e6a9f79..0a3cd0ef57 100644
--- a/bsd-user/freebsd/os-proc.h
+++ b/bsd-user/freebsd/os-proc.h
@@ -219,4 +219,43 @@ static inline abi_long do_freebsd_vfork(void *cpu_env)
return do_freebsd_fork(cpu_env);
}
+/* rfork(2) */
+static inline abi_long do_freebsd_rfork(void *cpu_env, abi_long flags)
+{
+ abi_long ret;
+ abi_ulong child_flag;
+
+ /*
+ * XXX We need to handle RFMEM here, as well. Neither are safe to execute
+ * as-is on x86 hosts because they'll split memory but not the stack,
+ * wreaking havoc on host architectures that use the stack to store the
+ * return address as both threads try to pop it off. Rejecting RFSPAWN
+ * entirely for now is ok, the only consumer at the moment is posix_spawn
+ * and it will fall back to classic vfork(2) if we return EINVAL.
+ */
+ if ((flags & TARGET_RFSPAWN) != 0) {
+ return -TARGET_EINVAL;
+ }
+ fork_start();
+ ret = rfork(flags);
+ if (ret == 0) {
+ /* child */
+ child_flag = 1;
+ target_cpu_clone_regs(cpu_env, 0);
+ } else {
+ /* parent */
+ child_flag = 0;
+ }
+
+ /*
+ * The fork system call sets a child flag in the second return
+ * value: 0 for parent process, 1 for child process.
+ */
+ set_second_rval(cpu_env, child_flag);
+ fork_end(child_flag);
+
+ return ret;
+
+}
+
#endif /* BSD_USER_FREEBSD_OS_PROC_H */
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index cb9425c9ba..4c4e773d1d 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -234,6 +234,10 @@ static abi_long freebsd_syscall(void *cpu_env, int num,
abi_long arg1,
ret = do_freebsd_vfork(cpu_env);
break;
+ case TARGET_FREEBSD_NR_rfork: /* rfork(2) */
+ ret = do_freebsd_rfork(cpu_env, arg1);
+ break;
+
case TARGET_FREEBSD_NR_execve: /* execve(2) */
ret = do_freebsd_execve(arg1, arg2, arg3);
break;
--
2.42.0
- [PATCH v5 17/28] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2)., (continued)
- [PATCH v5 17/28] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2)., Karim Taha, 2023/09/25
- [PATCH v5 18/28] bsd-user: Implement getpriority(2) and setpriority(2)., Karim Taha, 2023/09/25
- [PATCH v5 19/28] bsd-user: Implement get_filename_from_fd., Karim Taha, 2023/09/25
- [PATCH v5 20/28] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve., Karim Taha, 2023/09/25
- [PATCH v5 22/28] bsd-user: Implement execve(2) and fexecve(2) system calls., Karim Taha, 2023/09/25
- [PATCH v5 23/28] bsd-user: Implement wait4(2) and wait6(2) system calls., Karim Taha, 2023/09/25
- [PATCH v5 21/28] bsd-user: Implement procctl(2) along with necessary conversion functions., Karim Taha, 2023/09/25
- [PATCH v5 24/28] bsd-user: Implement setloginclass(2) and getloginclass(2) system calls., Karim Taha, 2023/09/25
- [PATCH v5 25/28] bsd-user: Implement pdgetpid(2) and the undocumented setugid., Karim Taha, 2023/09/25
- [PATCH v5 28/28] bsd-user: Implement pdfork(2) system call., Karim Taha, 2023/09/25
- [PATCH v5 27/28] bsd-user: Implement rfork(2) system call.,
Karim Taha <=
- [PATCH v5 26/28] bsd-user: Implement fork(2) and vfork(2) system calls., Karim Taha, 2023/09/25
- Re: [PATCH v5 00/28] bsd-user: Implement freebsd process related system calls., Warner Losh, 2023/09/27