qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 39/52] migration/rdma: Convert qemu_rdma_write_one() to Error


From: Zhijian Li (Fujitsu)
Subject: Re: [PATCH 39/52] migration/rdma: Convert qemu_rdma_write_one() to Error
Date: Tue, 26 Sep 2023 05:24:30 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0


On 18/09/2023 22:41, Markus Armbruster wrote:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job.  When the caller does, the error is reported twice.  When it
> doesn't (because it recovered from the error), there is no error to
> report, i.e. the report is bogus.
> 
> qemu_rdma_write_flush() violates this principle: it calls
> error_report() via qemu_rdma_write_one().  I elected not to
> investigate how callers handle the error, i.e. precise impact is not
> known.
> 
> Clean this up by converting qemu_rdma_write_one() to Error.
> 
> Signed-off-by: Markus Armbruster<armbru@redhat.com>


Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]