Re: [PATCH 45/52] migration/rdma: Silence qemu_rdma_connect()

[Zhijian Li (Fujitsu)]

On 18/09/2023 22:41, Markus Armbruster wrote:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job.  When the caller does, the error is reported twice.  When it
> doesn't (because it recovered from the error), there is no error to
> report, i.e. the report is bogus.
> 
> qemu_rdma_connect() violates this principle: it calls error_report()
> and perror().  I elected not to investigate how callers handle the
> error, i.e. precise impact is not known.
> 
> Clean this up: replace perror() by changing error_setg() to
> error_setg_errno(), and drop error_report().  I believe the callers'
> error reports suffice then.  If they don't, we need to convert to
> Error instead.
> 
> Signed-off-by: Markus Armbruster<armbru@redhat.com>

Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>