[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC V2 33/37] target/arm/kvm: Write CPU state back to KVM on rese
From: |
Salil Mehta |
Subject: |
[PATCH RFC V2 33/37] target/arm/kvm: Write CPU state back to KVM on reset |
Date: |
Tue, 26 Sep 2023 11:36:50 +0100 |
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
When a KVM vCPU is reset following a PSCI CPU_ON call, its power state
is not synchronized with KVM at the moment. Because the vCPU is not
marked dirty, we miss the call to kvm_arch_put_registers() that writes
to KVM's MP_STATE. Force mp_state synchronization.
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
target/arm/kvm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 0e1d0692b1..8e7c68af6a 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -614,11 +614,12 @@ void kvm_arm_cpu_post_load(ARMCPU *cpu)
void kvm_arm_reset_vcpu(ARMCPU *cpu)
{
int ret;
+ CPUState *cs = CPU(cpu);
/* Re-init VCPU so that all registers are set to
* their respective reset values.
*/
- ret = kvm_arm_vcpu_init(CPU(cpu));
+ ret = kvm_arm_vcpu_init(cs);
if (ret < 0) {
fprintf(stderr, "kvm_arm_vcpu_init failed: %s\n", strerror(-ret));
abort();
@@ -635,6 +636,12 @@ void kvm_arm_reset_vcpu(ARMCPU *cpu)
* for the same reason we do so in kvm_arch_get_registers().
*/
write_list_to_cpustate(cpu);
+
+ /*
+ * Ensure we call kvm_arch_put_registers(). The vCPU isn't marked dirty if
+ * it was parked in KVM and is now booting from a PSCI CPU_ON call.
+ */
+ cs->vcpu_dirty = true;
}
void kvm_arm_create_host_vcpu(ARMCPU *cpu)
--
2.34.1
- [PATCH RFC V2 25/37] arm/virt: Add/update basic hot-(un)plug framework, (continued)
- [PATCH RFC V2 25/37] arm/virt: Add/update basic hot-(un)plug framework, Salil Mehta, 2023/09/26
- [PATCH RFC V2 26/37] arm/virt: Changes to (un)wire GICC<->vCPU IRQs during hot-(un)plug, Salil Mehta, 2023/09/26
- [PATCH RFC V2 27/37] hw/arm, gicv3: Changes to update GIC with vCPU hot-plug notification, Salil Mehta, 2023/09/26
- [PATCH RFC V2 28/37] hw/intc/arm-gicv3*: Changes required to (re)init the vCPU register info, Salil Mehta, 2023/09/26
- [PATCH RFC V2 29/37] arm/virt: Update the guest(via GED) about CPU hot-(un)plug events, Salil Mehta, 2023/09/26
- [PATCH RFC V2 30/37] hw/arm: Changes required for reset and to support next boot, Salil Mehta, 2023/09/26
- [PATCH RFC V2 31/37] physmem, gdbstub: Common helping funcs/changes to *unrealize* vCPU, Salil Mehta, 2023/09/26
- [PATCH RFC V2 32/37] target/arm: Add support of *unrealize* ARMCPU during vCPU Hot-unplug, Salil Mehta, 2023/09/26
- [PATCH RFC V2 35/37] hw/arm: Support hotplug capability check using _OSC method, Salil Mehta, 2023/09/26
- Re: [PATCH RFC V2 35/37] hw/arm: Support hotplug capability check using _OSC method, Gavin Shan, 2023/09/29
- [PATCH RFC V2 36/37] tcg/mttcg: enable threads to unregister in tcg_ctxs[], Salil Mehta, 2023/09/26
- [PATCH RFC V2 37/37] hw/arm/virt: Expose cold-booted CPUs as MADT GICC Enabled, Salil Mehta, 2023/09/26