[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] m68k: Silence -Wshadow=local warnings in the m68k code
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] m68k: Silence -Wshadow=local warnings in the m68k code |
Date: |
Tue, 26 Sep 2023 15:15:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Thomas Huth <thuth@redhat.com> writes:
> On 26/09/2023 14.19, Markus Armbruster wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>>
>>> Rename the innermost variables to make the code compile
>>> without warnings when using -Wshadow=local.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>
>> Clashes with patches from Philippe and Laurent:
>>
>> [PATCH v2 05/22] target/m68k: Clean up local variable shadowing
>> [PATCH] disas/m68k: clean up local variable shadowing
>>
>> You guys figure out how to combine them, please :)
>
> Ok, then never mind about my patch.
> Anyway, it's getting confusing what has already been fixed and what not ...
> could you please pick up all patches that are available so far and send a
> pull request for them?
I'm collecting at https://repo.or.cz/qemu/armbru.git in branch
shadow-next. I'll send a new summary shortly. I intend to send a PR,
but first I need to collect R-bys and drop patches that aren't ready, if
any.