Re: [PATCH] mailmap: Fix Andrey Drobyshev author email

[Peter Maydell]

On Tue, 26 Sept 2023 at 14:40, Eric Blake <eblake@redhat.com> wrote:
>
> On Tue, Sep 26, 2023 at 01:28:01PM +0300, andrey.drobyshev@virtuozzo.com 
> wrote:
> > From: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> >
> > This fixes authorship of commits 2848289168, 52b10c9c0c as the mailing
> > list rewrote the "From:" field in the corresponding patches.  See commit
> > 3bd2608db7 ("maint: Add .mailmap entries for patches claiming list
> > authorship") for explanation.
> >
> > Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> > ---
> >  .mailmap | 1 +
> >  1 file changed, 1 insertion(+)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Hi Eric -- you wrote commit 3bd2608db72997, which included the
comment for this bit of .mailmap:

+# Next, translate a few commits where mailman rewrote the From: line due
+# to strict SPF, although we prefer to avoid adding more entries like that.

What did you mean by "we prefer to avoid adding more entries" ?
It reads to me like "don't add more entries even if we get more
accidental attributed-to-the-list commits" (and I was actually
thinking about replying to this patch to say "the mailmap file
says we shouldn't add more of these lines"), but presumably since
you've reviewed this patch that wasn't the actual intention.
Maybe the comment could use clarification.

thanks
-- PMM