[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] hw/arm/smmuv3.c: Avoid shadowing variable
From: |
Eric Auger |
Subject: |
Re: [PATCH 3/4] hw/arm/smmuv3.c: Avoid shadowing variable |
Date: |
Tue, 26 Sep 2023 17:00:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
Hi Peter,
On 9/22/23 17:29, Peter Maydell wrote:
> Avoid shadowing a variable in smmuv3_notify_iova():
>
> ../../hw/arm/smmuv3.c: In function ‘smmuv3_notify_iova’:
> ../../hw/arm/smmuv3.c:1043:23: warning: declaration of ‘event’ shadows a
> previous local [-Wshadow=local]
> 1043 | SMMUEventInfo event = {.inval_ste_allowed = true};
> | ^~~~~
> ../../hw/arm/smmuv3.c:1038:19: note: shadowed declaration is here
> 1038 | IOMMUTLBEvent event;
> | ^~~~~
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/arm/smmuv3.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index 1e9be8e89af..6f2b2bd45f9 100644
> --- a/hw/arm/smmuv3.c
> +++ b/hw/arm/smmuv3.c
> @@ -1040,8 +1040,8 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
> SMMUv3State *s = sdev->smmu;
>
> if (!tg) {
> - SMMUEventInfo event = {.inval_ste_allowed = true};
> - SMMUTransCfg *cfg = smmuv3_get_config(sdev, &event);
> + SMMUEventInfo eventinfo = {.inval_ste_allowed = true};
> + SMMUTransCfg *cfg = smmuv3_get_config(sdev, &eventinfo);
> SMMUTransTableInfo *tt;
>
> if (!cfg) {
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks!
Eric
- [PATCH 0/4] arm: fix some -Wshadow warnings, Peter Maydell, 2023/09/22
- [PATCH 1/4] hw/intc/arm_gicv3_its: Avoid shadowing variable in do_process_its_cmd(), Peter Maydell, 2023/09/22
- [PATCH 2/4] hw/misc/arm_sysctl.c: Avoid shadowing local variable, Peter Maydell, 2023/09/22
- [PATCH 3/4] hw/arm/smmuv3.c: Avoid shadowing variable, Peter Maydell, 2023/09/22
- [PATCH 4/4] hw/arm/smmuv3-internal.h: Don't use locals in statement macros, Peter Maydell, 2023/09/22
- Re: [PATCH 0/4] arm: fix some -Wshadow warnings, Markus Armbruster, 2023/09/29