|
From: | Gavin Shan |
Subject: | Re: [PATCH] target/arm/kvm64.c: Remove unused include |
Date: | Wed, 27 Sep 2023 17:19:52 +1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 |
On 9/25/23 21:04, Peter Maydell wrote:
The include of hw/arm/virt.h in kvm64.c is unnecessary and also a layering violation since the generic KVM code shouldn't need to know anything about board-specifics. The include line is an accidental leftover from commit 15613357ba53a4763, where we cleaned up the code to not depend on virt board internals but forgot to also remove the now-redundant include line. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/arm/kvm64.c | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Gavin Shan <gshan@redhat.com>
diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 5e95c496bb9..3ea9f1d6743 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -30,7 +30,6 @@ #include "internals.h" #include "hw/acpi/acpi.h" #include "hw/acpi/ghes.h" -#include "hw/arm/virt.h"static bool have_guest_debug;
[Prev in Thread] | Current Thread | [Next in Thread] |